DEV: Update linting (#127)

CvX · web-flow · commit 8991040a372c · 2025-03-17T11:42:09.000Z
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,80 +1,93 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.3.3)
+    activesupport (8.0.2)
       base64
+      benchmark (>= 0.3)
       bigdecimal
-      concurrent-ruby (~> 1.0, >= 1.0.2)
+      concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
       minitest (>= 5.1)
-      mutex_m
-      tzinfo (~> 2.0)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
     ast (2.4.2)
     base64 (0.2.0)
-    bigdecimal (3.1.8)
-    concurrent-ruby (1.2.3)
-    connection_pool (2.4.1)
+    benchmark (0.4.0)
+    bigdecimal (3.1.9)
+    concurrent-ruby (1.3.5)
+    connection_pool (2.5.0)
     drb (2.2.1)
-    i18n (1.14.5)
+    i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.7.2)
-    language_server-protocol (3.17.0.3)
-    minitest (5.23.1)
-    mutex_m (0.2.0)
-    parallel (1.24.0)
-    parser (3.3.1.0)
+    json (2.10.2)
+    language_server-protocol (3.17.0.4)
+    lint_roller (1.1.0)
+    logger (1.6.6)
+    minitest (5.25.5)
+    parallel (1.26.3)
+    parser (3.3.7.1)
       ast (~> 2.4.1)
       racc
     prettier_print (1.2.1)
-    racc (1.8.0)
-    rack (3.0.12)
+    racc (1.8.1)
+    rack (3.1.12)
     rainbow (3.1.1)
-    regexp_parser (2.9.2)
-    rexml (3.3.9)
-    rubocop (1.64.0)
+    regexp_parser (2.10.0)
+    rubocop (1.74.0)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.31.3)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.38.1)
       parser (>= 3.3.1.0)
-    rubocop-capybara (2.20.0)
-      rubocop (~> 1.41)
-    rubocop-discourse (3.8.0)
+    rubocop-capybara (2.22.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-discourse (3.12.1)
       activesupport (>= 6.1)
-      rubocop (>= 1.59.0)
-      rubocop-capybara (>= 2.0.0)
-      rubocop-factory_bot (>= 2.0.0)
-      rubocop-rails (>= 2.25.0)
-      rubocop-rspec (>= 2.25.0)
-    rubocop-factory_bot (2.25.1)
-      rubocop (~> 1.41)
-    rubocop-rails (2.25.0)
+      lint_roller (>= 1.1.0)
+      rubocop (>= 1.73.2)
+      rubocop-capybara (>= 2.22.0)
+      rubocop-factory_bot (>= 2.27.0)
+      rubocop-rails (>= 2.30.3)
+      rubocop-rspec (>= 3.0.1)
+      rubocop-rspec_rails (>= 2.31.0)
+    rubocop-factory_bot (2.27.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-rails (2.30.3)
       activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.33.0, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rspec (2.29.2)
-      rubocop (~> 1.40)
-      rubocop-capybara (~> 2.17)
-      rubocop-factory_bot (~> 2.22)
-      rubocop-rspec_rails (~> 2.28)
-    rubocop-rspec_rails (2.28.3)
-      rubocop (~> 1.40)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rspec (3.5.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-rspec_rails (2.31.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+      rubocop-rspec (~> 3.5)
     ruby-progressbar (1.13.0)
+    securerandom (0.4.1)
     syntax_tree (6.2.0)
       prettier_print (>= 1.2.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.5.0)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
+    uri (1.0.3)
 
 PLATFORMS
   ruby
@@ -84,4 +97,4 @@ DEPENDENCIES
   syntax_tree
 
 BUNDLED WITH
-   2.5.10
+   2.6.6
diff --git a/assets/javascripts/discourse/api-initializers/intitialize-whos-online-indicators.gjs b/assets/javascripts/discourse/api-initializers/intitialize-whos-online-indicators.gjs
@@ -40,11 +40,14 @@ export default apiInitializer((api) => {
       }
   );
 
-  api.renderInOutlet("above-user-profile", <template>
-    {{#if (userOnline @outletArgs.model.id)}}
-      {{bodyClass "user-page-online"}}
-    {{/if}}
-  </template>);
+  api.renderInOutlet(
+    "above-user-profile",
+    <template>
+      {{#if (userOnline @outletArgs.model.id)}}
+        {{bodyClass "user-page-online"}}
+      {{/if}}
+    </template>
+  );
 
   if (siteSettings.whos_online_avatar_indicator_topic_lists) {
     const addLastPosterOnlineClassNameTransformer = ({
diff --git a/assets/javascripts/discourse/services/whos-online.js b/assets/javascripts/discourse/services/whos-online.js
@@ -6,6 +6,7 @@ import Site from "discourse/models/site";
 export default class WhosOnlineService extends Service {
   @service presence;
   @service appEvents;
+
   @readOnly("channel.users") users;
   @readOnly("channel.count") count;
   @readOnly("channel.countOnly") countOnly;
diff --git a/assets/stylesheets/whos_online.scss b/assets/stylesheets/whos_online.scss
@@ -4,9 +4,13 @@
   padding-bottom: 5px;
 
   a {
-    transition: margin-right 1s, margin-left 1s, opacity 0.5s;
+    transition:
+      margin-right 1s,
+      margin-left 1s,
+      opacity 0.5s;
     transition-delay: 1s;
     opacity: 1;
+
     &.is-hidden {
       opacity: 0;
     }
@@ -15,19 +19,19 @@
   &.collapsed {
     a {
       margin-right: -15px;
-      margin-left: 0px;
+      margin-left: 0;
     }
 
     &:hover a {
-      margin-left: 0px;
-
-      margin-right: 0px;
+      margin-left: 0;
+      margin-right: 0;
 
       &:first-of-type {
-        margin-left: 0px;
+        margin-left: 0;
       }
+
       &:last-of-type {
-        margin-right: 0px;
+        margin-right: 0;
       }
     }
   }
@@ -67,32 +71,46 @@ html.whos-online-glow {
 
 html.whos-online-ring {
   #user-card.user-online .user-card-avatar img.avatar {
-    box-shadow: 0 0 0 2px var(--secondary), 0 0 0 5px var(--success-medium);
+    box-shadow:
+      0 0 0 2px var(--secondary),
+      0 0 0 5px var(--success-medium);
   }
 
   .topic-avatar.user-online img.avatar {
-    box-shadow: 0 0 0 1px var(--secondary), 0 0 0 3px var(--success-medium);
+    box-shadow:
+      0 0 0 1px var(--secondary),
+      0 0 0 3px var(--success-medium);
   }
 
   .topic-map .avatars .user-online img.avatar {
-    box-shadow: 0 0 0 1px var(--secondary), 0 0 0 2px var(--success-medium);
+    box-shadow:
+      0 0 0 1px var(--secondary),
+      0 0 0 2px var(--success-medium);
   }
 
   &.mobile-view .topic-list-item.last-poster-online img.avatar {
-    box-shadow: 0 0 0 1px var(--secondary), 0 0 0 3px var(--success-medium);
+    box-shadow:
+      0 0 0 1px var(--secondary),
+      0 0 0 3px var(--success-medium);
   }
 
   .latest-topic-list .latest-topic-list-item.last-poster-online img.avatar {
-    box-shadow: 0 0 0 1px var(--secondary), 0 0 0 3px var(--success-medium);
+    box-shadow:
+      0 0 0 1px var(--secondary),
+      0 0 0 3px var(--success-medium);
   }
 
   body.user-page-online .primary img.avatar {
-    box-shadow: 0 0 0 2px var(--secondary), 0 0 0 5px var(--success-medium);
+    box-shadow:
+      0 0 0 2px var(--secondary),
+      0 0 0 5px var(--success-medium);
     margin: 8px;
   }
 
   body.user-page-online .collapsed-info .primary img.avatar {
-    box-shadow: 0 0 0 1px var(--secondary), 0 0 0 3px var(--success-medium);
+    box-shadow:
+      0 0 0 1px var(--secondary),
+      0 0 0 3px var(--success-medium);
     margin: 5px;
   }
 }
@@ -135,6 +153,7 @@ html.whos-online-flair {
     // Add some spacing to the avatars
     margin-left: 5px;
   }
+
   .topic-map .avatars .user-online::before {
     @extend .whos-online-flair-prototype;
     top: -1px;
@@ -146,6 +165,7 @@ html.whos-online-flair {
   &.mobile-view .topic-list-item.last-poster-online div.pull-left {
     position: relative;
   }
+
   &.mobile-view .topic-list-item.last-poster-online div.pull-left::before {
     @extend .whos-online-flair-prototype;
     top: -1px;
@@ -157,6 +177,7 @@ html.whos-online-flair {
   .latest-topic-list .latest-topic-list-item.last-poster-online .topic-poster {
     position: relative;
   }
+
   .latest-topic-list
     .latest-topic-list-item.last-poster-online
     .topic-poster::before {
diff --git a/package.json b/package.json
@@ -1,10 +1,11 @@
 {
   "private": true,
   "devDependencies": {
-    "@discourse/lint-configs": "2.4.0",
-    "ember-template-lint": "6.1.0",
-    "eslint": "9.19.0",
-    "prettier": "2.8.8"
+    "@discourse/lint-configs": "2.11.1",
+    "ember-template-lint": "7.0.1",
+    "eslint": "9.22.0",
+    "prettier": "3.5.3",
+    "stylelint": "16.16.0"
   },
   "engines": {
     "node": ">= 22",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/stylelint.config.mjs b/stylelint.config.mjs
