Skip to content

Commit aa89202

Browse files
authored
system-specs: Remove note about LOAD_PLUGINS (#49)
This is now automatic so no need to include it manually. See discourse/discourse@1f46aed
1 parent 4ad19f1 commit aa89202

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

docs/02-development-environments/03-docker-setup.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,5 +144,5 @@ Or even something like this to be even more specific:
144144

145145
```sh
146146
my-machine:~/discourse$ d/shell
147-
discourse@discourse:/src$ LOAD_PLUGINS=1 RAILS_ENV=test /src/bin/rspec plugins/discourse-follow/spec/lib/updater_spec.rb:37
147+
discourse@discourse:/src$ RAILS_ENV=test /src/bin/rspec plugins/discourse-follow/spec/lib/updater_spec.rb:37
148148
```

docs/03-code-internals/20-system-specs.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ There are various environment flags that can be used to change how the spec is r
2626

2727
- `SELENIUM_HEADLESS` - Set to `0` to open a browser while the spec is running. This will allow you to observe what is going on while the browser is being driven by the test harness. Combine with debugging tools and Chrome devtools to help write and debug specs.
2828
- `CHROME_DEV_TOOLS` - Set to a position (`top|bottom|left|right`) to automatically open the Chrome devtools when a browser is launched with `SELENIUM_HEADLESS=0`. Greatly aids with debugging, since you can set `debugger` statements in any of our Ember code.
29-
- `LOAD_PLUGINS` - If you are writing system specs for plugins you must set this to `1` and you must run the plugin system spec from your root discourse repo, e.g. `LOAD_PLUGINS=1 bin/rspec plugins/discourse-docs/spec/system/FILENAME.rb`
3029

3130
### Rarely Used
3231

@@ -358,7 +357,7 @@ There are many more examples in `spec/system/page_objects/components`.
358357

359358
### Plugins
360359

361-
Plugin system specs work in the same way as core system specs, but must be run from the directory of the discourse core repo, using the environment flag `LOAD_PLUGINS=1`.
360+
Plugin system specs work in the same way as core system specs, but must be run from the directory of the discourse core repo.
362361

363362
### I18n
364363

0 commit comments

Comments
 (0)