Skip to content

Commit e23c311

Browse files
authored
DEV: Use Rails autoloading (#321)
This commit enables Rails autoloading for Data Explorer. See: https://meta.discourse.org/t/structuring-a-plugin-for-rails-autoloading/256092
1 parent d31d899 commit e23c311

File tree

5 files changed

+3
-9
lines changed

5 files changed

+3
-9
lines changed

lib/discourse_data_explorer/engine.rb

+3
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,8 @@ module ::DiscourseDataExplorer
44
class Engine < ::Rails::Engine
55
engine_name PLUGIN_NAME
66
isolate_namespace DiscourseDataExplorer
7+
config.autoload_paths << File.join(config.root, "lib")
8+
scheduled_job_dir = "#{config.root}/app/jobs/scheduled"
9+
config.to_prepare { Rails.autoloaders.main.eager_load_dir(scheduled_job_dir) }
710
end
811
end
File renamed without changes.
File renamed without changes.

plugin.rb

-9
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,6 @@ module ::DiscourseDataExplorer
3232
require_relative "lib/discourse_data_explorer/engine"
3333

3434
after_initialize do
35-
require_relative "app/jobs/scheduled/delete_hidden_queries"
36-
require_relative "lib/discourse_data_explorer/data_explorer"
37-
require_relative "lib/discourse_data_explorer/parameter"
38-
require_relative "lib/discourse_data_explorer/queries"
39-
require_relative "lib/discourse_data_explorer/query_group_bookmarkable"
40-
4135
GlobalSetting.add_default(:max_data_explorer_api_reqs_per_10_seconds, 2)
4236

4337
# Available options:
@@ -77,9 +71,6 @@ module ::DiscourseDataExplorer
7771
{ run_queries: { actions: %w[discourse_data_explorer/query#run], params: %i[id] } },
7872
)
7973

80-
require_relative "lib/report_generator"
81-
require_relative "lib/result_to_markdown"
82-
require_relative "lib/result_format_converter"
8374
reloadable_patch do
8475
if defined?(DiscourseAutomation)
8576
add_automation_scriptable("recurring_data_explorer_result_pm") do

0 commit comments

Comments
 (0)