DEV: Add specs

Author: keegangeorge

admin/assets/javascripts/discourse/templates/admin-plugins/show/discourse-ai-features/index.gjs

@@ -61,7 +61,10 @@ export default RouteTemplate(
 
               <tbody>
                 {{#each this.configuredFeatures as |feature|}}
-                  <tr class="ai-feature-list__row d-admin-row__content">
+                  <tr
+                    class="ai-feature-list__row d-admin-row__content"
+                    data-feature-name={{feature.name}}
+                  >
                     <td class="d-admin-row__overview ai-feature-list__row-item">
                       <span class="ai-feature-list__row-item-name">
                         <strong>
@@ -72,15 +75,19 @@ export default RouteTemplate(
                         {{feature.description}}
                       </span>
                     </td>
-                    <td class="d-admin-row__detail ai-feature-list__row-item">
+                    <td
+                      class="d-admin-row__detail ai-feature-list__row-item ai-feature-list__persona"
+                    >
                       <DButton
                         class="btn-flat btn-small ai-feature-list__row-item-persona"
                         @translatedLabel={{feature.persona.name}}
                         @route="adminPlugins.show.discourse-ai-personas.edit"
                         @routeModels={{feature.persona.id}}
                       />
                     </td>
-                    <td class="d-admin-row__detail ai-feature-list__row-item">
+                    <td
+                      class="d-admin-row__detail ai-feature-list__row-item ai-feature-list__groups"
+                    >
                       {{#if (gt feature.persona.allowed_groups.length 0)}}
                         <ul class="ai-feature-list__row-item-groups">
                           {{#each feature.persona.allowed_groups as |group|}}
@@ -91,7 +98,7 @@ export default RouteTemplate(
                     </td>
                     <td class="d-admin-row_controls">
                       <DButton
-                        class="btn-small"
+                        class="btn-small edit"
                         @label="discourse_ai.features.list.edit"
                         @route="adminPlugins.show.discourse-ai-features.edit"
                         @routeModels={{feature.id}}
@@ -105,7 +112,7 @@ export default RouteTemplate(
         {{/if}}
 
         {{#if (gt this.unconfiguredFeatures.length 0)}}
-          <div class="ai-feature-list-editor__unconfigured-features">
+          <div class="ai-feature-list__unconfigured-features">
             <h3>{{i18n "discourse_ai.features.list.unconfigured_features"}}</h3>
 
             <table class="d-admin-table">

spec/requests/admin/ai_features_controller_spec.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+RSpec.describe DiscourseAi::Admin::AiFeaturesController do
+  let(:controller) { described_class.new }
+  fab!(:admin)
+  fab!(:group)
+  fab!(:llm_model)
+  fab!(:summarizer_persona) { Fabricate(:ai_persona) }
+  fab!(:alternate_summarizer_persona) { Fabricate(:ai_persona) }
+
+  before do
+    sign_in(admin)
+    SiteSetting.ai_bot_enabled = true
+    SiteSetting.discourse_ai_enabled = true
+  end
+
+  describe "#index" do
+    it "lists all features backed by personas" do
+      get "/admin/plugins/discourse-ai/ai-features.json"
+
+      expect(response.status).to eq(200)
+      expect(response.parsed_body["ai_features"].count).to eq(4)
+    end
+  end
+
+  describe "#edit" do
+    it "returns a success response" do
+      get "/admin/plugins/discourse-ai/ai-features/1/edit.json"
+      expect(response.parsed_body["name"]).to eq(I18n.t "discourse_ai.features.summarization.name")
+    end
+  end
+
+  describe "#update" do
+    before do
+      SiteSetting.ai_summarization_persona = summarizer_persona.id
+      SiteSetting.ai_summarization_enabled = true
+    end
+
+    it "updates the feature" do
+      expect(SiteSetting.ai_summarization_persona).to eq(summarizer_persona.id.to_s)
+      expect(SiteSetting.ai_summarization_enabled).to eq(true)
+
+      put "/admin/plugins/discourse-ai/ai-features/1.json",
+          params: {
+            ai_feature: {
+              enabled: false,
+              persona_id: alternate_summarizer_persona.id,
+            },
+          }
+
+      expect(SiteSetting.ai_summarization_persona).to eq(alternate_summarizer_persona.id.to_s)
+      expect(SiteSetting.ai_summarization_enabled).to eq(false)
+    end
+  end
+end

spec/serializers/ai_features_persona_serializer_spec.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+RSpec.describe AiFeaturesPersonaSerializer do
+  fab!(:admin)
+  fab!(:ai_persona)
+  fab!(:group)
+  fab!(:group_2) { Fabricate(:group) }
+
+  describe "serialized attributes" do
+    before do
+      ai_persona.allowed_group_ids = [group.id, group_2.id]
+      ai_persona.save!
+    end
+
+    context "when there is a persona with allowed groups" do
+      let(:allowed_groups) do
+        Group
+          .where(id: ai_persona.allowed_group_ids)
+          .pluck(:id, :name)
+          .map { |id, name| { id: id, name: name } }
+      end
+
+      it "display every participant" do
+        serialized = described_class.new(ai_persona, scope: Guardian.new(admin), root: nil)
+        expect(serialized.id).to eq(ai_persona.id)
+        expect(serialized.name).to eq(ai_persona.name)
+        expect(serialized.system_prompt).to eq(ai_persona.system_prompt)
+        expect(serialized.allowed_groups).to eq(allowed_groups)
+        expect(serialized.enabled).to eq(ai_persona.enabled)
+      end
+    end
+  end
+end

spec/system/admin_ai_features_spec.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+RSpec.describe "Admin AI features configuration", type: :system, js: true do
+  fab!(:admin)
+  fab!(:llm_model)
+  fab!(:summarization_persona) { Fabricate(:ai_persona) }
+  fab!(:group_1) { Fabricate(:group) }
+  fab!(:group_2) { Fabricate(:group) }
+  let(:page_header) { PageObjects::Components::DPageHeader.new }
+  let(:form) { PageObjects::Components::FormKit.new("form") }
+  let(:ai_features_page) { PageObjects::Pages::AdminAiFeatures.new }
+
+  before do
+    summarization_persona.allowed_group_ids = [group_1.id, group_2.id]
+    summarization_persona.save!
+    assign_fake_provider_to(:ai_summarization_model)
+    SiteSetting.ai_summarization_enabled = true
+    SiteSetting.ai_summarization_persona = summarization_persona.id
+    sign_in(admin)
+  end
+
+  it "lists all persona backed AI features separated by configured/unconfigured" do
+    ai_features_page.visit
+    expect(
+      ai_features_page
+        .configured_features_table
+        .find(".ai-feature-list__row-item .ai-feature-list__row-item-name")
+        .text,
+    ).to eq(I18n.t("discourse_ai.features.summarization.name"))
+
+    expect(ai_features_page).to have_configured_feature_items(1)
+    expect(ai_features_page).to have_unconfigured_feature_items(3)
+  end
+
+  it "lists the persona used for the corresponding AI feature" do
+    ai_features_page.visit
+    expect(ai_features_page).to have_feature_persona(summarization_persona.name)
+  end
+
+  it "lists the groups allowed to use the AI feature" do
+    ai_features_page.visit
+    expect(ai_features_page).to have_feature_groups([group_1.name, group_2.name])
+  end
+
+  it "can navigate the AI plugin with breadcrumbs" do
+    visit "/admin/plugins/discourse-ai/ai-features"
+    expect(page).to have_css(".d-breadcrumbs")
+    expect(page).to have_css(".d-breadcrumbs__item", count: 4)
+    find(".d-breadcrumbs__item", text: I18n.t("admin_js.admin.plugins.title")).click
+    expect(page).to have_current_path("/admin/plugins")
+  end
+
+  it "can edit the AI feature" do
+    ai_features_page.visit
+    ai_features_page.click_edit_feature(I18n.t("discourse_ai.features.summarization.name"))
+    expect(page).to have_current_path("/admin/plugins/discourse-ai/ai-features/1/edit")
+    expect(page).to have_css(
+      ".ai-feature-editor__header h2",
+      text: I18n.t("discourse_ai.features.summarization.name"),
+    )
+
+    form.field("persona_id").select(-6)
+    form.submit
+    expect(page).to have_current_path("/admin/plugins/discourse-ai/ai-features")
+    expect(ai_features_page).to have_feature_persona(
+      I18n.t("discourse_ai.ai_bot.personas.creative.name"),
+    )
+  end
+end

spec/system/page_objects/pages/admin_ai_features.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+module PageObjects
+  module Pages
+    class AdminAiFeatures < PageObjects::Pages::Base
+      CONFIGURED_FEATURES_TABLE = ".ai-feature-list__configured-features .d-admin-table"
+      UNCONFIGURED_FEATURES_TABLE = ".ai-feature-list__unconfigured-features .d-admin-table"
+
+      def visit
+        page.visit("/admin/plugins/discourse-ai/ai-features")
+        self
+      end
+
+      def configured_features_table
+        page.find(CONFIGURED_FEATURES_TABLE)
+      end
+
+      def unconfigured_features_table
+        page.find(UNCONFIGURED_FEATURES_TABLE)
+      end
+
+      def has_configured_feature_items?(count)
+        page.has_css?("#{CONFIGURED_FEATURES_TABLE} .ai-feature-list__row", count: count)
+      end
+
+      def has_unconfigured_feature_items?(count)
+        page.has_css?("#{UNCONFIGURED_FEATURES_TABLE} .ai-feature-list__row", count: count)
+      end
+
+      def has_feature_persona?(name)
+        page.has_css?(
+          "#{CONFIGURED_FEATURES_TABLE} .ai-feature-list__persona .d-button-label ",
+          text: name,
+        )
+      end
+
+      def has_feature_groups?(groups)
+        listed_groups = page.find("#{CONFIGURED_FEATURES_TABLE} .ai-feature-list__groups")
+        list_items = listed_groups.all("li", visible: true).map(&:text)
+
+        list_items.sort == groups.sort
+      end
+
+      def click_edit_feature(feature_name)
+        page.find(
+          "#{CONFIGURED_FEATURES_TABLE} .ai-feature-list__row[data-feature-name='#{feature_name}'] .edit",
+        ).click
+      end
+    end
+  end
+end