-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(voice): handle multiple transitions simultaneously #11100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11100 +/- ##
==========================================
+ Coverage 44.19% 44.51% +0.31%
==========================================
Files 313 312 -1
Lines 18092 17804 -288
Branches 1796 1786 -10
==========================================
- Hits 7996 7925 -71
+ Misses 10084 9867 -217
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Please describe the changes this PR makes and why it should be merged:
This makes it so multiple transitions can be handled properly, according to the DAVESessionManager sample code. This changes the private property
pendingTransitiontopendingTransitionsthat hold a map of transitions. I don't think that constitutes a breaking change since its a private property.Status and versioning classification: