Validate the new version during self-update

Author: morozov

box.json.dist

@@ -4,7 +4,6 @@
         "KevinGH\\Box\\Compactor\\Json",
         "KevinGH\\Box\\Compactor\\Php"
     ],
-    "check-requirements": false,
     "force-autodiscovery": true,
     "directories": [
         "shell"

composer.json

@@ -22,6 +22,7 @@
         "bin/phpbrew"
     ],
     "require": {
+        "php": "^5.3.9||^7.0||^8.0",
         "corneltek/cliframework": "3.0.x-dev#2650a53433854d43b91955e8f967c62ce07869d7",
         "corneltek/pearx": "^1.3.5",
         "corneltek/curlkit": "^1.0.11",

composer.lock

@@ -56,13 +56,34 @@ public function execute()
         chmod($tempFile, 0755);
         //todo we can check the hash here in order to make sure we have download the phar successfully
 
+        if (!$this->checkRequirements($tempFile)) {
+            unlink($tempFile);
+
+            throw new RuntimeException('Update failed');
+        }
+
         //move the tmp file to executable path
         if (!rename($tempFile, $script)) {
             throw new RuntimeException('Update Failed', 3);
         }
 
         $this->logger->info('Version updated.');
         system($script . ' init');
-        system($script . ' --version');
+    }
+
+    /**
+     * Check if the new version is compatible with the current runtime.
+     *
+     * This assumes that the binary will check the runtime requirements for any sub-command including `--version`.
+     *
+     * @param string $binary The path to the new PHPBrew version binary
+     *
+     * @return bool
+     */
+    private function checkRequirements($binary)
+    {
+        system(escapeshellcmd($binary) . ' --version', $code);
+
+        return $code === 0;
     }
 }