[Bug]: allocate() does not throw when given numeric strings as input

[classic0]

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

First off, thanks for the great library.

.allocate() function has unexpected behaviour when given falsy input.

Expected behavior

I expected an error:
TypeError: You must provide a non-empty array of numeric values greater than 0

Steps to reproduce

try {
    Dinero({ amount: 100 })
    .allocate([ '2', '98' ])
} catch (error) {
    console.log(error)
}

It never finishes nor throws meanwhile hogging memory.

The same for this:
.allocate([ 1, '98' ])

But this one yields the expected TypeError:
.allocate([ 'a', '98' ])

Version

1.9.1

Environment

14.17.3

Code of Conduct

• I agree to follow this project's Code of Conduct

[sarahdayan]

Hey @classic0, this seems like a v1 bug indeed, the function should either convert the input, or throw. In the meantime, I'd recommend making sure you feed Dinero.js with numbers only (using Number or parseInt on your inputs).

I'm not actively maintaining v1 but I do review PRs, so feel free to check the v1 branch if you want to take a stab at it.

[matheusfcorocher]

Hello @sarahdayan , I'm trying to fix the bug but I have doubt in allocate function. It should only accepts integer numbers in validation or float number can be accept too? For example, should allocate function accept these arguments?

Dinero({ amount: 100 }).allocate([48.5, 51.5 ])

[sarahdayan]

Hey @matheusfcorocher, and sorry for the late answer. Only integers should be accepted.