Skip to content

Commit d119225

Browse files
committed
import_media: warn on SVG images
1 parent f07e071 commit d119225

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

datasources/media_import/import_media.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ def after_create(query, dataset, request):
231231
# update the number of files in the dataset
232232
dataset.num_files = saved_files
233233
dataset.media_type = mime_type
234+
# TODO: use job's 'details' to save data to share/log?
234235
if skipped_files:
235236
# todo: this now doesn't actually get logged because the log is
236237
# re-initialised after after_create runs?
@@ -241,7 +242,16 @@ def process(self):
241242
"""
242243
Step 3: Ummmm, we kinda did everything
243244
"""
244-
self.dataset.log(f"Uploaded {self.parameters.get('num_files')} files of type {self.parameters.get('media_type')}")
245+
# Check for SVG files
246+
svg_warning = 0
247+
if self.parameters.get("media_type") == "image":
248+
for file in self.iterate_archive_contents(self.dataset.get_results_path()):
249+
if file.suffix == ".svg":
250+
if svg_warning == 0:
251+
self.dataset.log("SVG files may not be processed correctly by some 4CAT processors.")
252+
self.dataset.log(f"SVG file detected: {file.name}")
253+
svg_warning += 1
254+
self.dataset.update_status(f"Uploaded {self.parameters.get('num_files')} files of type {self.parameters.get('media_type')}{'' if svg_warning == 0 else f' ({svg_warning} SVG files; see log)'}", is_final=True)
245255
self.dataset.finish(self.parameters.get("num_files"))
246256

247257
@staticmethod

0 commit comments

Comments
 (0)