Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeming discrepancies between flake.nix in guide and what is generated by default #2037

Open
stephenbenedict opened this issue Jan 28, 2025 · 1 comment

Comments

@stephenbenedict
Copy link

stephenbenedict commented Jan 28, 2025

There seem to be discrepancies between the flake.nix shown in the guide under Configuring the Instance (under Deploying with deploy-to-nixos) and what is generated by default with ihp-new.

For example, the default flake.nix contains this in the flake-parts.lib.mkFlake block:

services.nginx = {
    virtualHosts."CHANGE-ME.com" =  {
        # Uncomment to have http auth with username `foo` and password `bar`.
        # basicAuth = { foo = "bar"; };
    };
};

but in the guide, you are instructed: "Make sure you put this into the flake-parts.lib.mkFlake block. The final flake.nix should look like this:" with a config that lacks the above nginx config. Maybe it was excluded for brevity but it is slightly confusing when first modifying flake.nix for NixOS deployment since the guide seems to imply that that whole chunk of flake.nix can be replaced with what is shown in the guide.

@amitaibu
Copy link
Collaborator

The flake.nix created with ihp-new is from here

So if the docs on the guide are wrong, they can be adjusted based on that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants