Sørger for at klienten ikke får breaking changes

Det er et poeng på nåværende tidpspunkt at vi ikke bumper en major-versjon
av klienten for å få brukere av versjon 5 til å oppgradere for bedre
håndtering av polling-execption

Author: Aleksander Sjåfjell

Digipost.Signature.Api.Client.Direct/DirectClient.cs

@@ -151,7 +151,7 @@ private JobStatusResponse CreateOkResponse(string requestContent, HttpResponseMe
         private JobStatusResponse CreateNoContentResponse(HttpResponseMessage requestResult)
         {
             _logger.LogDebug("Received empty response. No jobs have had their status changed.");
-            return JobStatusResponse.NoChanges(RequestHelper.GetNextPermittedPollTime(requestResult));
+            return JobStatusResponse.NoChangesWithPollTime(RequestHelper.GetNextPermittedPollTime(requestResult));
         }
 
         private static JobStatusResponse ParseResponseToJobStatusResponse(string requestContent, DateTime nextPermittedPollTime)

Digipost.Signature.Api.Client.Direct/JobStatusResponse.cs

@@ -8,13 +8,22 @@ namespace Digipost.Signature.Api.Client.Direct
 {
     public class JobStatusResponse
     {
-        public static JobStatusResponse NoChanges(DateTime nextPermittedPollTime)
+        [Obsolete("Use NoChangesWithPollTime instead, as this can be removed without further notice.") ]
+        public static JobStatusResponse NoChanges = new JobStatusResponse(null, null, JobStatus.NoChanges, null, null, DateTime.Now);
+        
+        public static JobStatusResponse NoChangesWithPollTime(DateTime nextPermittedPollTime)
         {
             return new JobStatusResponse(null, null, JobStatus.NoChanges, null, null, nextPermittedPollTime);
         } 
 
-        private long? _jobId;
+        private readonly long? _jobId;
 
+        [Obsolete("Use constructor with DateTime instead, as this can be removed without further notice.")]
+        public JobStatusResponse(long? jobId, string jobReference, JobStatus status, JobReferences references, List<Signature> signatures)
+            : this(jobId, jobReference, status, references, signatures, DateTime.Now)
+        {
+        }
+        
         public JobStatusResponse(long? jobId, string jobReference, JobStatus status, JobReferences references, List<Signature> signatures, DateTime nextPermittedPollTime )
         {
             _jobId = jobId;

Digipost.Signature.Api.Client.Portal/DataTransferObjects/DataTransferObjectConverter.cs

@@ -9,7 +9,7 @@
 
 namespace Digipost.Signature.Api.Client.Portal.DataTransferObjects
 {
-    internal class DataTransferObjectConverter
+    internal static class DataTransferObjectConverter
     {
         public static portalsignaturejobrequest ToDataTransferObject(Job job)
         {

Digipost.Signature.Api.Client.Portal/JobStatusChanged.cs

@@ -7,11 +7,20 @@ namespace Digipost.Signature.Api.Client.Portal
 {
     public class JobStatusChanged
     {
-        public static JobStatusChanged NoChanges(DateTime nextPermittedPollTime)
+        [Obsolete("Use NoChangesWithPollTime instead, as this can be removed without further notice.")]
+        public static JobStatusChanged NoChanges = new JobStatusChanged(0, null, JobStatus.NoChanges, null, null, DateTime.Now);
+
+        public static JobStatusChanged NoChangesWithPollTime(DateTime nextPermittedPollTime)
         {
             return new JobStatusChanged(0, null, JobStatus.NoChanges, null, null, nextPermittedPollTime);
-        } 
-        
+        }
+
+        [Obsolete("Use constructor with DateTime instead, as this can be removed without further notice.")]
+        public JobStatusChanged(long jobId, string jobReference, JobStatus status, ConfirmationReference confirmationReference, List<Signature> signatures)
+            : this(jobId, jobReference, status, confirmationReference, signatures, DateTime.Now)
+        {
+        }
+
         public JobStatusChanged(long jobId, string jobReference, JobStatus status, ConfirmationReference confirmationReference, List<Signature> signatures, DateTime nextPermittedPollTime)
         {
             JobId = jobId;

Digipost.Signature.Api.Client.Portal/PortalClient.cs

@@ -95,7 +95,7 @@ public async Task<JobStatusChanged> GetStatusChange(Sender sender = null)
         private JobStatusChanged CreateNoContentResponse(HttpResponseMessage requestResult)
         {
             _logger.LogDebug("No content response received.");
-            return JobStatusChanged.NoChanges(RequestHelper.GetNextPermittedPollTime(requestResult));
+            return JobStatusChanged.NoChangesWithPollTime(RequestHelper.GetNextPermittedPollTime(requestResult));
         }
 
         private JobStatusChanged CreateOkResponse(string requestContent, HttpResponseMessage requestResult)