Skip to content

Commit 5ce1a9c

Browse files
author
Simen Støa
authored
Merge pull request #401 from digipost/description-for-job
Adds possibility to describe direct signature job
2 parents f5aa695 + 46cb766 commit 5ce1a9c

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

Digipost.Signature.Api.Client.Core.Tests/Digipost.Signature.Api.Client.Core.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1212
</PackageReference>
1313
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
14-
<PackageReference Include="CompareNETObjects" Version="4.77.0" />
14+
<PackageReference Include="CompareNETObjects" Version="4.78.0" />
1515
<PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.0" />
1616
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="6.0.0" />
1717
<PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="6.0.0" />

Digipost.Signature.Api.Client.Direct.Tests/JobTests.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,20 @@ public void Simple_constructor()
2626
var documents = DomainUtility.GetSingleDirectDocument();
2727
var exitUrls = DomainUtility.GetExitUrls();
2828
var sender = CoreDomainUtility.GetSender();
29-
29+
var description = "Description";
3030
//Act
31-
var directJob = new Job("Job title", documents, signers, id, exitUrls, sender);
31+
var directJob = new Job("Job title", documents, signers, id, exitUrls, sender)
32+
{
33+
Description = description
34+
};
3235

3336
//Assert
3437
Assert.Equal(id, directJob.Reference);
3538
Assert.Equal(signers, directJob.Signers);
3639
Assert.Equal(documents, directJob.Documents);
3740
Assert.Equal(exitUrls, directJob.ExitUrls);
3841
Assert.Equal(sender, directJob.Sender);
42+
Assert.Equal(description, directJob.Description);
3943
}
4044
}
4145
}

Digipost.Signature.Api.Client.Direct/Internal/AsicE/DirectAsiceGenerator.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ public static DocumentBundle CreateAsice(Job job, X509Certificate2 certificate,
1212
var manifest = new Manifest(job.Title, job.Sender, job.Documents, job.Signers)
1313
{
1414
AuthenticationLevel = job.AuthenticationLevel,
15-
IdentifierInSignedDocuments = job.IdentifierInSignedDocuments
15+
IdentifierInSignedDocuments = job.IdentifierInSignedDocuments,
16+
Description = job.Description
1617
};
1718
var signature = new SignatureGenerator(certificate, job.Documents, manifest);
1819

Digipost.Signature.Api.Client.Direct/Job.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public Job(string title, IEnumerable<Document> documents, IEnumerable<Signer> si
3333

3434
public string Title { get; }
3535

36-
public string Description { get; }
36+
public string Description { get; set; }
3737

3838
public IEnumerable<Document> Documents { get; }
3939

0 commit comments

Comments
 (0)