Fix compiler warnings on missing return value.

Non-void functions in ReflectionProfileWrap should return something.
Also fix warning about unused variable.

Author: pavoljuhas

extensions/powderpatternbackground_ext.cpp

@@ -36,8 +36,7 @@ void _SetInterpPoints(PowderPatternBackground& b,
         PyObject* tth, PyObject* backgd)
 {
     // cout << "_SetInterpPoints:" << tth << ", " << backgd << endl;
-    const unsigned long ndim = PyArray_NDIM((PyObject*)tth);
-    // cout << "dimensions = " << ndim << endl;
+    // cout << "dimensions = " << PyArray_NDIM(tth) << endl;
     const unsigned long nb = *(PyArray_DIMS((PyObject*)tth));
     // cout << "nbPoints = " << nb << endl;
     CrystVector_REAL tth2(nb), backgd2(nb);

extensions/reflectionprofile_ext.cpp

@@ -18,6 +18,8 @@
 *****************************************************************************/
 
 #include <boost/python/class.hpp>
+#include <boost/python/manage_new_object.hpp>
+#include <boost/python/pure_virtual.hpp>
 
 #include <iostream>
 
@@ -32,22 +34,42 @@ namespace {
 class ReflectionProfileWrap :
     public ReflectionProfile, public wrapper<ReflectionProfile>
 {
-    //:TODO: :KLUDGE: Dummy override of pure virtual functions
     public:
-        ReflectionProfileWrap() : ReflectionProfile() {}
-        virtual ReflectionProfile* CreateCopy() const {}
-        virtual CrystVector_REAL GetProfile(
+
+        // Pure virtual functions
+
+        ReflectionProfile* CreateCopy() const
+        {
+            return this->get_override("CreateCopy")();
+        }
+
+        CrystVector_REAL GetProfile(
                 const CrystVector_REAL& x, const REAL xcenter,
                 const REAL h, const REAL k, const REAL l) const
-        {}
-        virtual REAL GetFullProfileWidth(
+        {
+            bp::override f = this->get_override("GetProfile");
+            return f(x, xcenter, h, k, l);
+        }
+
+        REAL GetFullProfileWidth(
                 const REAL relativeIntensity, const REAL xcenter,
                 const REAL h, const REAL k, const REAL l)
-        {}
-        virtual void XMLOutput(ostream& os, int indent) const
-        {}
-        virtual void XMLInput(istream& is, const XMLCrystTag& tag)
-        {}
+        {
+            bp::override f = this->get_override("GetFullProfileWidth");
+            return f(relativeIntensity, xcenter, h, k, l);
+        }
+
+        void XMLOutput(ostream& os, int indent) const
+        {
+            bp::override f = this->get_override("XMLOutput");
+            f(os, indent);
+        }
+
+        void XMLInput(istream& is, const XMLCrystTag& tag)
+        {
+            bp::override f = this->get_override("GetProfile");
+            f(is, tag);
+        }
 };
 
 }   // namespace
@@ -57,5 +79,9 @@ void wrap_reflectionprofile()
 {
     class_<ReflectionProfileWrap, bases<RefinableObj>, boost::noncopyable>(
             "ReflectionProfile")
+        // TODO add pure_virtual bindings to the remaining public methods
+        .def("CreateCopy",
+                pure_virtual(&ReflectionProfile::CreateCopy),
+                return_value_policy<manage_new_object>())
         ;
 }