Skip to content

Commit 2fe6286

Browse files
added test case of a wildcard in a file-list file
1 parent 0124e43 commit 2fe6286

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

src/diffpy/labpdfproc/tests/conftest.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ def user_filesystem(tmp_path):
3636
with open(input_dir / "binary.pkl", "wb") as f:
3737
f.write(binary_data)
3838

39+
with open(base_dir / "file_list.txt", "w") as f:
40+
f.write("./*.txt")
3941
with open(input_dir / "file_list.txt", "w") as f:
4042
f.write("good_data.chi \n good_data.xy \n good_data.txt \n missing_file.txt")
4143
with open(input_dir / "file_list_example2.txt", "w") as f:

src/diffpy/labpdfproc/tests/test_tools.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@
6565
["good_data*"],
6666
["good_data.chi", "good_data.xy", "good_data.txt"],
6767
),
68-
# wildcard pattern for file-list file, currently failing
69-
# (["input_dir/file_list*"], "file_list.txt"),
68+
# wildcard pattern in a file-list file
69+
(["file_list.txt"], ["good_data.txt", "unreadable_file.txt"]),
7070
]
7171

7272

src/diffpy/labpdfproc/tools.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,17 @@ def _expand_user_input(args):
4242
the arguments with the modified input list
4343
4444
"""
45-
wildcard_inputs = [input_name for input_name in args.input if "*" in input_name]
4645
file_list_inputs = [input_name for input_name in args.input if "file_list" in input_name]
47-
for wildcard_input in wildcard_inputs:
48-
input_files = [str(file) for file in Path(".").glob(wildcard_input)]
49-
args.input.extend(input_files)
50-
args.input.remove(wildcard_input)
5146
for file_list_input in file_list_inputs:
5247
with open(file_list_input, "r") as f:
5348
file_inputs = [input_name.strip() for input_name in f.readlines()]
5449
args.input.extend(file_inputs)
5550
args.input.remove(file_list_input)
51+
wildcard_inputs = [input_name for input_name in args.input if "*" in input_name]
52+
for wildcard_input in wildcard_inputs:
53+
input_files = [str(file) for file in Path(".").glob(wildcard_input) if "file_list" not in file.name]
54+
args.input.extend(input_files)
55+
args.input.remove(wildcard_input)
5656
return args
5757

5858

0 commit comments

Comments
 (0)