Skip to content

Commit 1643f8d

Browse files
committed
finalize tests
1 parent ab8f719 commit 1643f8d

File tree

2 files changed

+31
-12
lines changed

2 files changed

+31
-12
lines changed

src/diffpy/labpdfproc/tests/test_tools.py

Lines changed: 27 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from diffpy.labpdfproc.tools import (
99
known_sources,
1010
load_user_metadata,
11-
set_input_files,
11+
set_input_lists,
1212
set_output_directory,
1313
set_wavelength,
1414
)
@@ -34,7 +34,22 @@
3434
"input_dir/binary.pkl",
3535
],
3636
),
37-
( # list of files provided (we skip if encountering invalid files)
37+
( # glob list of input directories
38+
[".", "./input_dir"],
39+
[
40+
"./good_data.chi",
41+
"./good_data.xy",
42+
"./good_data.txt",
43+
"./unreadable_file.txt",
44+
"./binary.pkl",
45+
"input_dir/good_data.chi",
46+
"input_dir/good_data.xy",
47+
"input_dir/good_data.txt",
48+
"input_dir/unreadable_file.txt",
49+
"input_dir/binary.pkl",
50+
],
51+
),
52+
( # list of files provided (we skip if encountering missing files)
3853
["good_data.chi", "good_data.xy", "unreadable_file.txt", "missing_file.txt"],
3954
["good_data.chi", "good_data.xy", "unreadable_file.txt"],
4055
),
@@ -43,26 +58,26 @@
4358
["input_dir/good_data.chi", "good_data.chi"],
4459
),
4560
( # file_list.txt list of files provided
46-
["file_list_dir/file_list.txt"],
61+
["input_dir/file_list.txt"],
4762
["good_data.chi", "good_data.xy", "good_data.txt"],
4863
),
4964
( # file_list_example2.txt list of files provided in different directories
50-
["file_list_dir/file_list_example2.txt"],
65+
["input_dir/file_list_example2.txt"],
5166
["input_dir/good_data.chi", "good_data.xy", "input_dir/good_data.txt"],
5267
),
5368
]
5469

5570

5671
@pytest.mark.parametrize("inputs, expected", params_input)
57-
def test_set_input_files(inputs, expected, user_filesystem):
58-
expected_input_directory = []
59-
for expected_path in expected:
60-
expected_input_directory.append(Path(user_filesystem) / expected_path)
72+
def test_set_input_lists(inputs, expected, user_filesystem):
73+
base_dir = Path(user_filesystem)
74+
os.chdir(base_dir)
75+
expected_paths = [Path(user_filesystem).resolve() / expected_path for expected_path in expected]
6176

6277
cli_inputs = ["2.5"] + inputs
6378
actual_args = get_args(cli_inputs)
64-
actual_args = set_input_files(actual_args)
65-
assert set(actual_args.input_directory) == set(expected_input_directory)
79+
actual_args = set_input_lists(actual_args)
80+
assert actual_args.input_directory == expected_paths
6681

6782

6883
# This test is for existing single input file or directory absolute path not in cwd
@@ -83,7 +98,7 @@ def test_set_input_files_not_cwd(inputs, expected, user_filesystem):
8398

8499
cli_inputs = ["2.5"] + actual_input
85100
actual_args = get_args(cli_inputs)
86-
actual_args = set_input_files(actual_args)
101+
actual_args = set_input_lists(actual_args)
87102
assert set(actual_args.input_directory) == set(expected_input_directory)
88103

89104

@@ -100,7 +115,7 @@ def test_set_input_files_bad(inputs, msg, user_filesystem):
100115
cli_inputs = ["2.5"] + inputs
101116
actual_args = get_args(cli_inputs)
102117
with pytest.raises(ValueError, match=msg[0]):
103-
actual_args = set_input_files(actual_args)
118+
actual_args = set_input_lists(actual_args)
104119

105120

106121
# Pass files to loadData and use it to check if file is valid or not

src/diffpy/labpdfproc/tools.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ def set_output_directory(args):
2828
return output_dir
2929

3030

31+
def set_input_lists(args):
32+
return args
33+
34+
3135
def set_wavelength(args):
3236
"""
3337
Set the wavelength based on the given input arguments

0 commit comments

Comments
 (0)