Simplifier: do not create extractbits with pointer type

tautschnig · tautschnig · commit ed9cd5911418 · 2025-07-09T20:51:34.000Z
This is a fix-up for 525c23d: we must not remove typecasts towards pointers when the operand is extractbits as our back-ends do not support extractbits with pointer type.
diff --git a/src/util/simplify_expr.cpp b/src/util/simplify_expr.cpp
@@ -1342,7 +1342,7 @@ simplify_exprt::simplify_typecast(const typecast_exprt &expr)
   else if(auto extractbits = expr_try_dynamic_cast<extractbits_exprt>(operand))
   {
     if(
-      can_cast_type<bitvector_typet>(expr_type) &&
+      can_cast_type<bitvector_typet>(expr_type) && expr_type_id != ID_pointer &&
       can_cast_type<bitvector_typet>(operand.type()) &&
       to_bitvector_type(expr_type).get_width() ==
         to_bitvector_type(operand.type()).get_width())

Original file line number	Diff line number	Diff line change
`@@ -1342,7 +1342,7 @@ simplify_exprt::simplify_typecast(const typecast_exprt &expr)`
`1342`	`1342`	`else if(auto extractbits = expr_try_dynamic_cast<extractbits_exprt>(operand))`
`1343`	`1343`	`{`
`1344`	`1344`	`if(`
`1345`		`- can_cast_type<bitvector_typet>(expr_type) &&`
	`1345`	`+ can_cast_type<bitvector_typet>(expr_type) && expr_type_id != ID_pointer &&`
`1346`	`1346`	`can_cast_type<bitvector_typet>(operand.type()) &&`
`1347`	`1347`	`to_bitvector_type(expr_type).get_width() ==`
`1348`	`1348`	`to_bitvector_type(operand.type()).get_width())`