Skip to content

Commit df8461d

Browse files
committed
Invert condition on body availability check
In order to make it clear that functions with no body are not serialised, without reading the code below the if block.
1 parent 4890204 commit df8461d

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

src/goto-programs/write_goto_binary.cpp

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -86,36 +86,36 @@ static void write_goto_functions_binary(
8686

8787
for(const auto &fct : goto_functions.function_map)
8888
{
89-
if(fct.second.body_available())
90-
{
91-
// Since version 2, goto functions are not converted to ireps,
92-
// instead they are saved in a custom binary format
89+
if(!fct.second.body_available())
90+
continue;
91+
92+
// Since version 2, goto functions are not converted to ireps,
93+
// instead they are saved in a custom binary format
9394

94-
write_gb_string(out, id2string(fct.first)); // name
95-
write_gb_word(out, fct.second.body.instructions.size()); // # instructions
95+
write_gb_string(out, id2string(fct.first)); // name
96+
write_gb_word(out, fct.second.body.instructions.size()); // # instructions
9697

97-
for(const auto &instruction : fct.second.body.instructions)
98-
{
99-
irepconverter.reference_convert(instruction.code(), out);
100-
irepconverter.reference_convert(instruction.source_location(), out);
101-
write_gb_word(out, (long)instruction.type());
98+
for(const auto &instruction : fct.second.body.instructions)
99+
{
100+
irepconverter.reference_convert(instruction.code(), out);
101+
irepconverter.reference_convert(instruction.source_location(), out);
102+
write_gb_word(out, (long)instruction.type());
102103

103-
const auto condition =
104-
instruction.has_condition() ? instruction.condition() : true_exprt();
105-
irepconverter.reference_convert(condition, out);
104+
const auto condition =
105+
instruction.has_condition() ? instruction.condition() : true_exprt();
106+
irepconverter.reference_convert(condition, out);
106107

107-
write_gb_word(out, instruction.target_number);
108+
write_gb_word(out, instruction.target_number);
108109

109-
write_gb_word(out, instruction.targets.size());
110+
write_gb_word(out, instruction.targets.size());
110111

111-
for(const auto &t_it : instruction.targets)
112-
write_gb_word(out, t_it->target_number);
112+
for(const auto &t_it : instruction.targets)
113+
write_gb_word(out, t_it->target_number);
113114

114-
write_gb_word(out, instruction.labels.size());
115+
write_gb_word(out, instruction.labels.size());
115116

116-
for(const auto &l_it : instruction.labels)
117-
irepconverter.write_string_ref(out, l_it);
118-
}
117+
for(const auto &l_it : instruction.labels)
118+
irepconverter.write_string_ref(out, l_it);
119119
}
120120
}
121121
}

0 commit comments

Comments
 (0)