Skip to content

Commit 6cbc63b

Browse files
committed
Use same CMake minimum version in DownloadProject configuration
We already have a top-level minimum requirement for CMake >= 3.8, so don't need to specify a lower requirement in a file included from the top level. Having a requirement as low as 2.8.2 broke building on newer version of CMake, which error with "Compatibility with CMake < 3.5 has been removed from CMake." (seen in GitHub runners with Ubuntu 24.04).
1 parent cd39b3a commit 6cbc63b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/pull-request-checks.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
- name: Build with make
5252
run: |
5353
git clone https://github.com/conp-solutions/riss riss.git
54-
cmake -Hriss.git -Briss.git/release -DCMAKE_BUILD_TYPE=Release
54+
cmake -Hriss.git -Briss.git/release -DCMAKE_BUILD_TYPE=Release -DCMAKE_POLICY_VERSION_MINIMUM=3.5
5555
make -C riss.git/release riss-coprocessor-lib-static -j${{env.linux-vcpus}}
5656
make -C src -j${{env.linux-vcpus}} CXX="ccache g++" LIBS="$PWD/riss.git/release/lib/libriss-coprocessor.a -lpthread" IPASIR=$PWD/riss.git/riss
5757
make -C jbmc/src -j${{env.linux-vcpus}} CXX="ccache g++" LIBS="$PWD/riss.git/release/lib/libriss-coprocessor.a -lpthread" IPASIR=$PWD/riss.git/riss

cmake/DownloadProject.CMakeLists.cmake.in

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Distributed under the OSI-approved MIT License. See accompanying
22
# file LICENSE or https://github.com/Crascit/DownloadProject for details.
33

4-
cmake_minimum_required(VERSION 2.8.2)
4+
cmake_minimum_required(VERSION 3.8)
55

66
project(${DL_ARGS_PROJ}-download NONE)
77

0 commit comments

Comments
 (0)