Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not require samples tsv for assembly-based workflows #82

Closed
bluegenes opened this issue Feb 10, 2019 · 1 comment
Closed

do not require samples tsv for assembly-based workflows #82

bluegenes opened this issue Feb 10, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@bluegenes
Copy link
Member

(to do)

Right now, tsv file input is required whether or not we're using the reads (e.g. annotation does not require reads). This file is parsed directly in the snakefile.

To fix: in Snakefile, check all workflows within the config to see if any contain read extensions, meaning that they work on reads. If yes, parse the samples.tsv. Then add a check into run_eelpond to exit if the config doesn't contain either samples or assemblyinput.

@bluegenes bluegenes added the enhancement New feature or request label Feb 10, 2019
@bluegenes bluegenes self-assigned this Feb 10, 2019
@bluegenes bluegenes changed the title require *either* tsv *or* assemblyinput do not require samples tsv for assembly-based workflows Feb 10, 2019
@bluegenes
Copy link
Member Author

manage samples via the get_data utility and params. Only look for/ use samples file if config.yml contains:

get_data: 
  samples: tsv_file

in snakefile, only read in the samples file if get_data params are present/provided. This should also be checked/ managed by the high-level inputs, err checking function (#110)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant