Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'quantify' target is currently failing. #28

Closed
ctb opened this issue Jan 23, 2019 · 5 comments
Closed

'quantify' target is currently failing. #28

ctb opened this issue Jan 23, 2019 · 5 comments

Comments

@ctb
Copy link
Member

ctb commented Jan 23, 2019

% ./run_eelpond nema-download.yaml quantify

--------
checking for required files:
--------

        Added default parameters from rule-specific params files.
        Writing full params to .ep_nema-download.yaml
--------
details!
        snakefile: /home/diblions/eelpond/Snakefile
        config: nema-download.yaml
        params: .ep_nema-download.yaml
        targets: ['quantify']
        report: '/home/diblions/eelpond/nema_out/logs/report.html'
--------
Building DAG of jobs...
MissingInputException in line 46 of /home/diblions/eelpond/rules/salmon/salmon.rule:
Missing input files for rule salmon_index:
/home/diblions/eelpond/nema_out/assembly/__assembly__.fasta```
@bluegenes
Copy link
Member

See docs. Need to have either generated an assembly or pass an assembly in via the config.

Todo: add informative error message.

@ctb
Copy link
Member Author

ctb commented Jan 23, 2019 via email

@bluegenes
Copy link
Member

bluegenes commented Jan 23, 2019

ok, yes. Can you check ./run_eelpond nema-download assemble quantify? Should work. The problem is that we need to pass an assembly name in for salmon to properly build target files. I'll upd docs.

Two options here:

  1. assume user wants to quantify on all existing assemblies:
    • have run_eelpond find assemblies in the assembly directory, pass all in.
  2. Don't assume this and write a more informative message
  3. Assume (and this is true for now) that the user is only running a Trinity assembly. Add trinity as an included rule in the quantify specification in ep_utils/pipeline_defaults.yaml. Caveats: 1) also need to include khmer rule, and 2) this would mean trinity assembly is run if it hasn't been already, even if the user passes in an assembly via assemblyinput.

Note: option 1 probably fails with plass assemblies, but we could specify all but plass...

@bluegenes
Copy link
Member

bluegenes commented Jan 23, 2019

I should note that preprocess, assemble, quantify and diffexp are attempts at being a bit smarter about what the user wants by including all rules that are necessary for those steps (e.g. make sure we include the get_data rule prior to running trimmomatic).

The user could also include all these rules on the command line: ./run_eelpond nema-test get_data trimmomatic fastqc is functionally equivalent to ./run_eelpond nema-test preprocess, though the targets passed to snakemake are a bit redundant if specifying individual rules.

All of these "subworkflows" / workflows are specified in ep_utils/pipeline_defaults.yaml.

Hopefully this will be a bit clearer when I finish up the docs!

@bluegenes
Copy link
Member

specific example here is being addressed in #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants