Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Coloring lighting from PS1 version #7641

Open
Maderator3000 opened this issue Jan 10, 2025 · 2 comments
Open

[Feature Request]: Coloring lighting from PS1 version #7641

Maderator3000 opened this issue Jan 10, 2025 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@Maderator3000
Copy link
Contributor

Feature Type

Other (please specify)

Describe

I have already written about color lighting in my past issue, but I was told that it is better to recreate a separate issue for lighting, although not necessarily.

The different colors of light seem logical in themselves and will definitely add variety to the game's color scheme. Torches emit orange-yellow light, the player and mobs emit white, acid emits green, light from various magics (not only from the player) and so on.

IMG_20250111_023537
IMG_20250111_024147

The first screenshot was taken in DevilutionX. It can be seen that white light is coming from both the player and the torch. The second screenshot was taken in Diablo PS1 on the emulator. I chose the place where it is most clearly visible that the player is emitting white light, and the torch is orange-yellow.

IMG_20250111_024432
IMG_20250111_024500

With the heat of the screenshots lowered, the difference is much better seen.

@Maderator3000 Maderator3000 added the enhancement New feature or request label Jan 10, 2025
@julealgon
Copy link
Contributor

Related (just linking for reference):

@StephenCWills
Copy link
Member

I was told that it is better to recreate a separate issue for lighting

I did say that it's better to open separate issues for separate proposals, but I also said that I'm not sure if it's useful to track this since it's not possible to do it right now. I'll just put this under the 1.7 milestone, I guess, so we can maybe revisit it later.

@StephenCWills StephenCWills added this to the 1.7.0 milestone Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants