Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Changing the logic of the Quit Game #7790

Open
Maderator3000 opened this issue Feb 27, 2025 · 2 comments
Open

[Feature Request]: Changing the logic of the Quit Game #7790

Maderator3000 opened this issue Feb 27, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@Maderator3000
Copy link
Contributor

Feature Type

Quality of Life

Describe

Quit Game on Android opens the menu, which is very convenient, but on Windows it closes the program, which is why you have to use New Game during the game to open the menu.

You can simply change the logic of the Quit Game from exiting the program to exiting the program menu, but it's not a fact that everyone will like it, so I see the best option for adding settings to the logic of the button - either it closes the DevX, or it exits into its menu. You can also add a transition option to the list of characters in a single-player or online game, depending on which one the player leaves.

@Maderator3000 Maderator3000 added the enhancement New feature or request label Feb 27, 2025
@julealgon
Copy link
Contributor

...but it's not a fact that everyone will like it, so I see the best option for adding settings to the logic of the button

I strongly dislike this reasoning for adding a setting.

The project cannot please everyone at the same time. Adding settings in an attempt to do that incurs maintainability costs to the project along with other issues.

I think proposing a new flow for the menu options is fine (this has been discussed already):

But making it conditional based on settings.... I hope that does not get implemented.

@kphoenix137
Copy link
Collaborator

Feature Type

Quality of Life

Describe

Quit Game on Android opens the menu, which is very convenient, but on Windows it closes the program, which is why you have to use New Game during the game to open the menu.

You can simply change the logic of the Quit Game from exiting the program to exiting the program menu, but it's not a fact that everyone will like it, so I see the best option for adding settings to the logic of the button - either it closes the DevX, or it exits into its menu. You can also add a transition option to the list of characters in a single-player or online game, depending on which one the player leaves.

I disagree with this suggestion entirely. Returning to the main menu means that "New Game" and "Quit Game" are effectively the same thing. It's probably the way it is on Android because the in game button isn't able to close the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants