Skip to content

Commit a6212b6

Browse files
Fix log error in oauth.py (databricks#269)
* Duplicate of applicable change from databricks#93 Signed-off-by: Jesse Whitehouse <[email protected]> * Update changelog Signed-off-by: Jesse Whitehouse <[email protected]> * Fix after merge Signed-off-by: Levko Kravets <[email protected]> --------- Signed-off-by: Jesse Whitehouse <[email protected]> Signed-off-by: Levko Kravets <[email protected]> Co-authored-by: Levko Kravets <[email protected]>
1 parent 6949aba commit a6212b6

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Release History
22

3+
# (Unreleased)
4+
5+
- Fix: our logger would raise an uncaught exception under certain oauth error conditions
6+
37
# 3.1.2 (2024-04-18)
48

59
- Remove broken cookie code (#379)

src/databricks/sql/auth/oauth.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def __get_authorization_code(self, client, auth_url, scope, state, challenge):
125125
logger.info(f"Port {port} is in use")
126126
last_error = e
127127
except Exception as e:
128-
logger.error("unexpected error", e)
128+
logger.error("unexpected error: %s", e)
129129
if self.redirect_port is None:
130130
logger.error(
131131
f"Tried all the ports {self.port_range} for oauth redirect, but can't find free port"

0 commit comments

Comments
 (0)