Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests! #2

Open
dgw opened this issue May 1, 2016 · 0 comments
Open

Tests! #2

dgw opened this issue May 1, 2016 · 0 comments
Assignees
@dgw
Labels
enhancement

Comments

@dgw
Copy link
Owner

dgw commented May 1, 2016

The module really should have tests, and the cookiecutter template did generate a no-op tests file that's just waiting to be used.

Consideration: API requires a key.
Possible solution: Separate test key config file that user must edit.
Alternate possible solution: Store full API responses for use with output methods so as not to hit the API more than necessary (useful for avoiding hitting W|A's free limits if development pace ever speeds up).
@dgw dgw self-assigned this May 1, 2016
@dgw dgw added the enhancement label May 1, 2016
dgw added a commit that referenced this issue May 10, 2016
@dgw
Refactor to separate query method from bot command
5837e96 
Will be needed when implementing tests for #2, because tests cannot (easily?)
access the bot object, or test the output of e.g. bot.say() if they could.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgw dgw

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgw