Skip to content

ineffecient / incorrect classpath handling #86

@maxandersen

Description

@maxandersen

I think this is a change after #76 suggested refactor - if not - still an issue :)

paths.forEach(jShell::addToClasspath);

this line is in a method that takes a list of strings that are calling addtoclasspath which is an expensive operation (semi-restart jshell)
and it treats the string as classpath separated by path Seprator.....thats fine - but then iterate those via extension loader as if they are paths to individual paths...

  • that latter will fail if actually given a classpath
  • this add to path is quite ineffecient to and is also used in maven magics ...so if you add something with lets say 5 dependencies it is noticably slower.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions