feat(Governance): Adapt node_provider_remuneration tests for PBR

rs/nns/governance/src/governance.rs

@@ -270,7 +270,7 @@ pub(crate) const LOG_PREFIX: &str = "[Governance] ";
 
 /// The number of seconds between automated Node Provider reward events
 /// Currently 1/12 of a year: 2629800 = 86400 * 365.25 / 12
-const NODE_PROVIDER_REWARD_PERIOD_SECONDS: u64 = 2629800;
+pub const NODE_PROVIDER_REWARD_PERIOD_SECONDS: u64 = 2629800;
 
 const VALID_MATURITY_MODULATION_BASIS_POINTS_RANGE: RangeInclusive<i32> = -500..=500;
 

rs/nns/governance/src/lib.rs

@@ -219,7 +219,7 @@ thread_local! {
 }
 
 thread_local! {
-    static ARE_PERFORMANCE_BASED_REWARDS_ENABLED: Cell<bool> = const { Cell::new(false) };
+    static ARE_PERFORMANCE_BASED_REWARDS_ENABLED: Cell<bool> = const { Cell::new(cfg!(feature = "test")) };
 }
 
 pub(crate) fn are_performance_based_rewards_enabled() -> bool {

rs/nns/governance/tests/fake.rs

@@ -48,7 +48,11 @@ use ic_nns_governance::governance::tla::{
     self, Destination, TLA_INSTRUMENTATION_STATE, ToTla, account_to_tla, tla_function,
 };
 use ic_nns_governance::{tla_log_request, tla_log_response};
+use ic_node_rewards_canister_api::RewardsCalculationAlgorithmVersion;
 use ic_node_rewards_canister_api::monthly_rewards::GetNodeProvidersMonthlyXdrRewardsResponse;
+use ic_node_rewards_canister_api::providers_rewards::{
+    GetNodeProvidersRewardsResponse, NodeProvidersRewards,
+};
 
 lazy_static! {
     pub(crate) static ref SNS_ROOT_CANISTER_ID: PrincipalId = PrincipalId::new_user_test_id(213599);
@@ -612,6 +616,19 @@ impl Environment for FakeDriver {
             .unwrap());
         }
 
+        if method_name == "get_node_providers_rewards" {
+            assert_eq!(PrincipalId::from(target), NODE_REWARDS_CANISTER_ID.get());
+
+            let response: GetNodeProvidersRewardsResponse = Ok(NodeProvidersRewards {
+                rewards_xdr_permyriad: btreemap! {
+                    PrincipalId::new_user_test_id(1).0 => NODE_PROVIDER_REWARD,
+                },
+                algorithm_version: RewardsCalculationAlgorithmVersion::default(),
+            });
+
+            return Ok(Encode!(&response).unwrap());
+        }
+
         if method_name == "get_average_icp_xdr_conversion_rate" {
             assert_eq!(PrincipalId::from(target), CYCLES_MINTING_CANISTER_ID.get());
 

rs/nns/governance/tests/governance.rs

@@ -1354,7 +1354,7 @@ async fn test_mint_monthly_node_provider_rewards() {
         xdr_conversion_rate,
         minimum_xdr_permyriad_per_icp,
         maximum_node_provider_rewards_e8s,
-        registry_version,
+        registry_version: _,
         node_providers,
         algorithm_version: _,
     } = most_recent_monthly_node_provider_rewards;
@@ -1369,8 +1369,6 @@ async fn test_mint_monthly_node_provider_rewards() {
         maximum_node_provider_rewards_e8s,
         Some(default_economics.maximum_node_provider_rewards_e8s)
     );
-    // It happens to be 5, we just want to ensure it is set.
-    assert_eq!(registry_version, Some(5));
     assert_eq!(node_providers.len(), 1);
 }
 

rs/nns/integration_tests/BUILD.bazel

@@ -124,8 +124,10 @@ DEV_DEPENDENCIES = [
     "//rs/nervous_system/common/test_utils",
     "//rs/nervous_system/integration_tests:nervous_system_integration_tests",
     "//rs/nns/test_utils/golden_nns_state",
+    "//rs/node_rewards/rewards_calculation",
     "//rs/test_utilities/metrics",
     "//rs/types/types_test_utils",
+    "@crate_index//:chrono_canisters",
     "@crate_index//:ic-cbor",
     "@crate_index//:ic-certificate-verification",
     "@crate_index//:ic-certification",
@@ -158,6 +160,7 @@ DEV_DATA = [
     "//rs/nns/handlers/root/impl:root-canister",
     "//rs/nns/sns-wasm:sns-wasm-canister",
     "//rs/node_rewards/canister:node-rewards-canister",
+    "//rs/node_rewards/canister:node-rewards-canister-test",
     "//rs/pocket_ic_server:pocket-ic-server",
     "//rs/registry/canister:registry-canister",
     "//rs/registry/canister:registry-canister-test",
@@ -188,6 +191,7 @@ DEV_ENV = {
     "CYCLES_MINTING_CANISTER_WASM_PATH": "$(rootpath //rs/nns/cmc:cycles-minting-canister)",
     "MEM_UTILS_TEST_CANISTER_WASM_PATH": "$(rootpath :mem-utils-test-canister)",
     "NODE_REWARDS_CANISTER_WASM_PATH": "$(rootpath //rs/node_rewards/canister:node-rewards-canister)",
+    "NODE_REWARDS_CANISTER_TEST_WASM_PATH": "$(rootpath //rs/node_rewards/canister:node-rewards-canister-test)",
     "POCKET_IC_BIN": "$(rootpath //rs/pocket_ic_server:pocket-ic-server)",
     "CANISTER_PLAYGROUND_CANISTER_WASM_PATH": "$(rootpath :canister-playground-canister)",
     "SNS_WASM_CANISTER_WASM_PATH": "$(rootpath //rs/nns/sns-wasm:sns-wasm-canister)",

rs/nns/integration_tests/Cargo.toml

@@ -120,3 +120,5 @@ ic-nervous-system-integration-tests = { path = "../../nervous_system/integration
 ic-nns-test-utils-golden-nns-state = { path = "../test_utils/golden_nns_state" }
 ic-registry-canister-api = { path = "../../registry/canister/api" }
 pretty_assertions = { workspace = true }
+rewards-calculation = { path = "../../node_rewards/rewards_calculation" }
+chrono = { workspace = true }