Control panel for simulations #443

lemniscate8 · 2021-08-04T01:36:11Z

Add a Button group from Bootstrap
Add a toggle button group that is double click safe
- Can configure as a cassette style or play/pause style button
- Can gray out inactive state for stronger visual indication
Add a control panel
- Interface for adding buttons
- Support different call rates to an simulation (function to run) and viewports (components to redraw)

codecov · 2021-08-04T02:03:55Z

Codecov Report

Merging #443 (414e349) into master (08c913f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   82.96%   82.97%   +0.01%     
==========================================
  Files         304      306       +2     
  Lines       37341    37393      +52     
==========================================
+ Hits        30979    31028      +49     
- Misses       6362     6365       +3

Impacted Files	Coverage Δ
include/emp/web/Div.hpp	`71.50% <ø> (ø)`
include/emp/datastructs/DisjointVariant.hpp	`100.00% <100.00%> (ø)`
include/emp/prefab/ToggleSwitch.hpp	`100.00% <100.00%> (ø)`
include/emp/web/Input.hpp	`41.13% <100.00%> (ø)`
tests/datastructs/DisjointVariant.cpp	`100.00% <100.00%> (ø)`
include/emp/Evolve/World_select.hpp	`96.01% <0.00%> (-0.40%)`	⬇️
include/emp/Evolve/World.hpp	`96.44% <0.00%> (-0.31%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c913f...414e349. Read the comment docs.

mmore500 · 2021-08-30T19:08:07Z

include/emp/prefab/ButtonGroup.hpp

+     * button group group.
+     * @param btn_group a button group
+     */
+    ButtonGroup & TakeChildren(ButtonGroup & btn_group) {


If we're destroying it, maybe take as an R-value reference?

mmore500 · 2021-08-30T19:08:38Z

include/emp/prefab/ButtonGroup.hpp

+
+    protected:
+    /**
+     * The protected contructor for a ButtonGroup.


Mention the README.md or somewhere else where the design pattern is explained

include/emp/prefab/ButtonGroup.hpp

mmore500 · 2021-08-30T19:10:40Z

include/emp/prefab/ButtonGroup.hpp

+  };
+}
+
+#endif


// #ifndef EMP_BUTTON_GROUP_HPP
(here and all the other files)

mmore500 · 2021-08-30T19:53:33Z

include/emp/prefab/ToggleButtonGroup.hpp

+    }
+
+    /**
+     * Get the function to be called when the component toggles


Why do end users need this?

Good point :D

mmore500 · 2021-08-30T19:53:54Z

include/emp/prefab/ToggleButtonGroup.hpp

+
+    /**
+     * Set the function to be called when the component toggles
+     * @param cb a callback function that accepts a boolean indicating


a void callback function

mmore500 · 2021-08-30T19:55:06Z

include/emp/web/Div.hpp

    class TableInfo;
    class DivInfo : public internal::WidgetInfo {
      friend Element; friend Div; friend TableInfo;
+      friend prefab::ButtonGroup;


Why do ButtonGroup and ControlPanel need to be friends? What are they needing to access inside of Div???

They need to be able to construct a DivInfo instance but the constructor is protected.

How did we get around this with other prefab components? It would be best to try to preserve levilization if possible (although these predeclares aren’t a /huge/ issue).

mmore500 · 2021-08-30T19:55:46Z

include/emp/web/Div.hpp

    // Get a properly cast version of info.
    internal::DivInfo * Info() { return (internal::DivInfo *) info; }
    const internal::DivInfo * Info() const { return (internal::DivInfo *) info; }
+    Div(internal::DivInfo * in_info) : WidgetFacet(in_info) { ; }


Add some space, an explanatory comment, and info about where design pattern is explained.

mmore500 · 2021-08-30T19:56:16Z

tests/web/ControlPanel.cpp

+struct Test_Control_Panel : emp::web::BaseTest {
+/*
+ * Creates extra div + the following control panel structure
+ *    +------------------+------+-----+-------------------+  +---+---+---+  +--+


D | A | B ??? XD

Also, C?

Can just add legend below

Still not sure what D, A, B and C are

This reverts commit b150900.

:x :wq

lemniscate8 added 9 commits August 2, 2021 11:54

Simple button group class

1d769c0

Idea for concatenating button groups

be39c0c

Toggle button setup for play/pause button

1a160a4

Some setup for the toggle button

ce2d52e

Fix switch styling in Bootstrap v5.0

8992466

Get toggle button working

22cb37f

Some documentation

033ac59

Add styling for imbedded toggle button groups

5db885f

Input works on radio buttons now

8f649f3

lemniscate8 self-assigned this Aug 4, 2021

lemniscate8 added Goal: Enhancement Topic: Web Interface labels Aug 4, 2021

lemniscate8 added 11 commits August 9, 2021 10:38

No need for components as members

6ebd496

Control panel basics

9f5a3fd

Allow grouping buttons in ControlPanel

875640b

No more control panel for now

7408f8f

Ironing out

2149bef

Use checker function

b9fcedc

Fix bug with toggle clicks

c2e1aa0

Optimize checker and fix reference issues

3ae3215

Document control panel

50ba064

Remove step button disabling

b099a3b

Add documentation

0d3256e

lemniscate8 requested a review from mmore500 August 21, 2021 00:39

lemniscate8 added 3 commits August 25, 2021 14:50

Swap rate and unit parameters in constructor

b0be177

Add unit test for control panel

5a4cc26

Test for ToggleButtonGroup

21f8b50

mmore500 requested changes Aug 30, 2021

View reviewed changes

Address feedback

d0faa5c

lemniscate8 and others added 23 commits September 3, 2021 14:52

More documentation

e4f3f2a

Simplify some stuff

ca489f3

Remove cout

2aac8ac

More descriptive template types

c9abe28

Explain DivInfo constructor for Div

8ba6455

Use map to hold checker instances

e3db915

Name change for clarity

6be2bb2

Merge branch 'master' into control-panel

892c1d0

Include string header

0ef6beb

Include string header

7bab656

Implement and test DisjointVariant

9179f2e

Use relative path for in-library includes

30e0ed1

Fix duplicated constructor

9927976

Add missing header

30ae1ca

Add Assign and Activate methods

e65067c

Refactor ControlPanel to use DisjointVariant

b150900

Add DyanmicRefreshChecker

359be34

Add zero-overhead static test

167ce5b

Buff DisjointVariant static asserts

4deacf4

Implement and test ApplyToAll

6083037

Mock up describe functions

eae6c72

Revert "Refactor ControlPanel to use DisjointVariant"

a656377

This reverts commit b150900.

Minor refactoring on @lemniscate8's approach

414e349

:x :wq

+                };
+              }
+              #endif

Control panel for simulations #443

Are you sure you want to change the base?

Control panel for simulations #443

Uh oh!

Conversation

lemniscate8 commented Aug 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lemniscate8 commented Aug 4, 2021 •

edited

Loading

codecov bot commented Aug 4, 2021 •

edited

Loading