Merge pull request #139 from devmehq/develop

develop

Author: meabed

.github/renovate.json

@@ -2,6 +2,10 @@
   "extends": [
     "config:base"
   ],
+  "branchPrefix": "renovate-",
+  "baseBranches": [
+    "develop"
+  ],
   "assigneesFromCodeOwners": true,
   "packageRules": [
     {

.github/workflows/ci.yml

@@ -1,40 +1,60 @@
-name: ci
+name: CI
 on:
+  workflow_dispatch:
+  workflow_call:
   push:
     paths:
       - 'src/**'
-      - 'test/**'
+      - '__tests__/**'
       - 'package.json'
       - 'yarn.lock'
+      - 'release.config.js'
+      - '.github/workflows/ci.yml'
     branches:
       - '*'
+      - '**'
+      - '!master'
 
 env:
+  NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   CI: true
 
 jobs:
-  build:
-    runs-on: ubuntu-18.04
+  CI:
+    runs-on: ubuntu-latest
     timeout-minutes: 20
 
+    permissions:
+      packages: write
+      contents: write
+
     steps:
+      - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
       - uses: styfle/[email protected]
         with:
-          workflow_id: build-docker.yml
+          workflow_id: ci.yml
           access_token: ${{ github.token }}
 
       - uses: actions/checkout@v3
         with:
           fetch-depth: 30
-          persist-credentials: false
-
-      - uses: bahmutov/npm-install@v1
 
-      - name: Yarn install
-        uses: bahmutov/npm-install@v1
+      - uses: FranzDiebold/github-env-vars-action@v2
+      - name: Setup Node.js
+        uses: actions/setup-node@v3
         with:
-          install-command: yarn --frozen-lockfile --silent
+          node-version: 19
+
+      - name: Yarn
+        run: yarn install --frozen-lockfile
 
       - name: Test
         run: |
           yarn test
+
+      - name: Release
+        if: github.ref == 'refs/heads/develop'
+        run: |
+          npm i -g semantic-release @semantic-release/git @semantic-release/github conventional-changelog-conventionalcommits
+          npx semantic-release --no-ci --debug

.github/workflows/release.yml

@@ -0,0 +1,53 @@
+name: Release
+on:
+  workflow_dispatch:
+  workflow_call:
+  push:
+    paths:
+      - 'src/**'
+      - 'yarn.lock'
+    branches:
+      - 'master'
+
+env:
+  NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+  CI: true
+
+jobs:
+  Release:
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+
+    permissions:
+      packages: write
+      contents: write
+
+    steps:
+      - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event."
+      - uses: styfle/[email protected]
+        with:
+          workflow_id: release.yml
+          access_token: ${{ github.token }}
+
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 30
+
+      - uses: FranzDiebold/github-env-vars-action@v2
+      - name: Setup Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: 19
+
+      - name: Yarn
+        run: yarn install --frozen-lockfile
+
+      - name: Test
+        run: |
+          yarn test
+
+      - name: Release
+        run: |
+          npm i -g semantic-release @semantic-release/git @semantic-release/github conventional-changelog-conventionalcommits
+          npx semantic-release --no-ci --debug

.husky/pre-commit

@@ -1,2 +1,2 @@
+node_modules/.bin/pretty-quick
 node_modules/.bin/lint-staged
-yarn run test

.mocharc.js

@@ -23,7 +23,7 @@ module.exports = {
   recursive: false,
   reporter: 'spec',
   require: ['ts-node/register', 'should'],
-  spec: ['./test/*-test.ts'],
+  spec: ['./__tests__/*-test.ts'],
   timeout: '8s',
   'trace-warnings': true,
 };

test/all-media-integration-test.ts renamed to __tests__/all-media-integration-test.ts

@@ -35,7 +35,7 @@ describe('basic', async function () {
     expect(result.favicon).to.be.eql('https://www.namecheap.com/assets/img/nc-icon/favicon.ico');
     expect(result.ogUrl).to.be.eql('https://www.namecheap.com/');
     expect(result.ogTitle).to.be.eql('Buy a domain name - Register cheap domain names from $0.99 - Namecheap');
-    expect(result.ogDescription).to.be.eql('Register domain names at Namecheap. Buy cheap domain names and enjoy 24/7 support. With over 13 million domains under management, you know you’re in good hands.');
+    expect(result.ogDescription).to.be.eql('Register domain names at Namecheap. Buy cheap domain names and enjoy 24/7 support. With over 16 million domains under management, you know you’re in good hands.');
     // expect(result.ogImage).to.be.an('array').and.to.not.be.empty;
     // expect(result.charset).to.be.eql('utf8');
     expect(result).to.have.all.keys(
@@ -148,7 +148,7 @@ describe('basic', async function () {
     expect(result.ogTitle).to.be.eql('Date.prototype.toLocaleString() - JavaScript | MDN');
     expect(result.ogLocale).to.be.eql('en-US');
     expect(result.ogUrl).to.be.eql('https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleString');
-    expect(result.ogDate).to.be.eql('2022-03-27T17:30:40.000Z');
+    expect(result.ogDate).to.be.eql('2022-12-21T06:06:58.000Z');
     expect(result.favicon).to.be.eql('/favicon-48x48.cbbd161b.png');
     // expect(result.charset).to.be.eql('utf8');
     expect(result.ogImage).to.be.eql({
@@ -172,16 +172,16 @@ describe('basic', async function () {
   });
   it('net-a-porter should return open graph data with one title', async function () {
     const result = await ogs({
-      url: 'https://www.net-a-porter.com/en-au/shop/product/gucci/shoes/mid-heel/plastique-logo-embossed-rubber-mules/1647597276960849',
+      url: 'https://www.net-a-porter.com/en-ca/shop/product/gucci/shoes/mid-heel/plastique-logo-embossed-rubber-mules/1647597276126997',
     });
-    expect(result.ogTitle).to.be.eql('Blue Plastique logo-embossed rubber mules | GUCCI | NET-A-PORTER');
+    expect(result.ogTitle).to.be.eql('Ivory Plastique logo-embossed rubber mules | GUCCI | NET-A-PORTER');
     expect(result.ogLocale).to.be.eql('en');
-    expect(result.ogUrl).to.be.eql('https://www.net-a-porter.com/en-au/shop/product/gucci/shoes/mid-heel/plastique-logo-embossed-rubber-mules/1647597276960849');
+    expect(result.ogUrl).to.be.eql('https://www.net-a-porter.com/en-ca/shop/product/gucci/shoes/mid-heel/plastique-logo-embossed-rubber-mules/1647597276126997');
     expect(result.ogDate).to.be.eql(undefined);
     expect(result.favicon).to.be.eql('/favicon.png');
     // expect(result.charset).to.be.eql('utf8');
     expect(result.ogImage).to.be.eql({
-      url: '//www.net-a-porter.com/variants/images/1647597276960849/in/w2000_q60.jpg',
+      url: '//www.net-a-porter.com/variants/images/1647597276126997/in/w2000_q60.jpg',
       width: null,
       height: null,
       type: 'jpg',