fix: resolve copilot comment

Author: Pavlo Kulyk

adminforth/dataConnectors/clickhouse.ts

@@ -500,9 +500,17 @@ class ClickhouseConnector extends AdminForthBaseConnector implements IAdminForth
     }
 
     async deleteMany({ resource, recordIds }: { resource: AdminForthResource; recordIds: any[] }): Promise<number> {
-      const idsList = recordIds.map(id => `'${id}'`).join(', ');
-      const query = `ALTER TABLE ${resource.table} DELETE WHERE ${this.getPrimaryKey(resource)} IN (${idsList})`;
-      const res = await this.client.query({ query });
+      const pkColumn = resource.dataSourceColumns.find((col) => col.primaryKey);
+      if (!pkColumn || !recordIds || recordIds.length === 0) {
+         return 0;
+       }
+      const paramNames = recordIds.map((_, idx) => `id${idx}`);
+      const conditions = paramNames.map((name) => `${pkColumn.name} = {${name}:${pkColumn._underlineType}}`).join(' OR ');
+      const queryParams = paramNames.reduce((acc, name, idx) => {acc[name] = recordIds[idx]; return acc;}, {} as Record<string, any>);
+      await this.client.command({
+        query: `ALTER TABLE ${this.dbName}.${resource.table} DELETE WHERE ${conditions}`,
+        query_params: queryParams,
+      });
       return recordIds.length ?? 0;
     }
 

adminforth/dataConnectors/postgres.ts

@@ -457,7 +457,7 @@ class PostgresConnector extends AdminForthBaseConnector implements IAdminForthDa
 
     async deleteMany({ resource, recordIds }: { resource: AdminForthResource; recordIds: any[] }): Promise<number> {
         const placeholders = recordIds.map((_, idx) => `$${idx + 1}`).join(', ');
-        const query = `DELETE FROM ${resource.table} WHERE ${this.getPrimaryKey(resource)} IN (${placeholders})`;
+        const query = `DELETE FROM "${resource.table}" WHERE "${this.getPrimaryKey(resource)}" IN (${placeholders})`;
         const res = await this.client.query(query, recordIds);
         return res.rowCount ?? 0;
     }

adminforth/types/Back.ts

@@ -292,8 +292,6 @@ export interface IAdminForthDataSourceConnectorBase extends IAdminForthDataSourc
   }): Promise<{ok: boolean, error?: string}>;
 
   getMinMaxForColumns({ resource, columns }: { resource: AdminForthResource, columns: AdminForthResourceColumn[] }): Promise<{ [key: string]: { min: any, max: any } }>;
-
-  deleteMany?(params: { resource: AdminForthResource; recordIds: any[] }): Promise<number>;
 }
 
 
@@ -1763,7 +1761,7 @@ export interface IOperationalResource {
 
   delete: (primaryKey: any) => Promise<boolean>;
 
-  deleteMany?(params: { resource: AdminForthResource; recordIds: any[] }): Promise<number>;
+  deleteMany?(recordIds: any[]): Promise<number>;
 
   dataConnector: IAdminForthDataSourceConnectorBase;
 }