Skip to content

Conversation

@beyondkmp
Copy link
Contributor

@beyondkmp beyondkmp commented Apr 12, 2025

fix electron-userland/electron-builder#8149

If the extraction fails,and if it is on Windows and the issue is that symbolic link files cannot be created,simply use the 7zip library in Go to extract again and filter out such files.

Such a modification won't affect previous extractions; it will only solve the problem of wincodesign tools failing during extraction on Windows.

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2025

🦋 Changeset detected

Latest commit: 6042715

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app-builder-bin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta
Copy link
Collaborator

mmaietta commented Apr 23, 2025

I like this change. But curious question. What if we were to split up the zip artifact so that it's downloaded per-platform? e.g., windows zip doesn't have symbolic links, only the mac zip artifact would.

Context:
I'm changing the release process of this repo to release all assets at once, so theoretically, we can easily change the way we zip artifacts to any new approach.
Example: https://github.com/mmaietta/electron-builder-binaries/releases/tag/untagged-30d4154bfdbaa9338d2a
Add in changesets/cli and GHA, and we can easily update binary versions via CI/CD with changelogs applied.

@beyondkmp
Copy link
Contributor Author

beyondkmp commented Apr 24, 2025

What if we were to split up the zip artifact so that it's downloaded per-platform? e.g., windows zip doesn't have symbolic links, only the mac zip artifact would.

I agree with this approach; it should be the most perfect solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to create dylib symbolic link on Windows

2 participants