Skip to content

**Bug:** The change from hasMoneyManagement to hasHosting incorrectly removes the balance display for organizations that have money management but are not hosts. #1556

@christama

Description

@christama

Bug: The change from hasMoneyManagement to hasHosting incorrectly removes the balance display for organizations that have money management but are not hosts.
Severity: HIGH

Suggested Fix

The condition should be updated to ensure organizations with money management see their balance. A potential solution is to display the balance-inclusive overview if account.hasHosting || hasMoneyManagement is true. Other host-specific components within the overview, like HostTodoList, should remain conditioned on account.hasHosting to avoid showing them to non-host organizations.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: components/dashboard/sections/overview/OrgOverview.tsx#L117-L120

Potential issue: The logic for displaying overview content was changed from checking
`hasMoneyManagement` to `account.hasHosting`. This introduces a functional regression
for organizations that have money management enabled but are not fiscal hosts.
Previously, these organizations would see `HostOverviewContent`, which includes their
account balance. After this change, they will see `OrgOverviewContent`, which omits the
balance metric. This removes a key piece of financial information for these
organizations, contradicting the acknowledged need for them to see their balance.

Did we get this right? 👍 / 👎 to inform future reviews.

Originally posted by @sentry in opencollective/opencollective-frontend#11860 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions