Implement HorizontalPodAutoscalerGenerator with custom model and focused tests (#362)

* Initial plan

* Implement HorizontalPodAutoscalerGenerator with custom models

Co-authored-by: devantler <[email protected]>

* refactor: consolidate redundant HorizontalPodAutoscalerGenerator tests

Co-authored-by: devantler <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: devantler <[email protected]>
Co-authored-by: Nikolai Emil Damm <[email protected]>

Author: Copilot

src/DevantlerTech.KubernetesGenerator.Native/HorizontalPodAutoscalerGenerator.cs

@@ -1,11 +1,11 @@
 using DevantlerTech.KubernetesGenerator.Core;
-using k8s.Models;
+using DevantlerTech.KubernetesGenerator.Native.Models;
 
 namespace DevantlerTech.KubernetesGenerator.Native;
 
 /// <summary>
-/// A generator for Kubernetes HorizontalPodAutoscaler objects.
+/// A generator for Kubernetes HorizontalPodAutoscaler objects with custom model.
 /// </summary>
-public class HorizontalPodAutoscalerGenerator : BaseKubernetesGenerator<V2HorizontalPodAutoscaler>
+public class HorizontalPodAutoscalerGenerator : BaseKubernetesGenerator<HorizontalPodAutoscaler>
 {
 }

src/DevantlerTech.KubernetesGenerator.Native/Models/HorizontalPodAutoscaler.cs

@@ -0,0 +1,27 @@
+namespace DevantlerTech.KubernetesGenerator.Native.Models;
+
+/// <summary>
+/// Represents a Kubernetes HorizontalPodAutoscaler for use with kubectl autoscale.
+/// </summary>
+public class HorizontalPodAutoscaler
+{
+  /// <summary>
+  /// Gets or sets the API version of this HorizontalPodAutoscaler.
+  /// </summary>
+  public string ApiVersion { get; set; } = "autoscaling/v2";
+
+  /// <summary>
+  /// Gets or sets the kind of this resource.
+  /// </summary>
+  public string Kind { get; set; } = "HorizontalPodAutoscaler";
+
+  /// <summary>
+  /// Gets or sets the metadata for the HorizontalPodAutoscaler.
+  /// </summary>
+  public required Metadata Metadata { get; set; }
+
+  /// <summary>
+  /// Gets or sets the specification for the HorizontalPodAutoscaler.
+  /// </summary>
+  public required HorizontalPodAutoscalerSpec Spec { get; set; }
+}

src/DevantlerTech.KubernetesGenerator.Native/Models/HorizontalPodAutoscalerScaleTargetRef.cs

@@ -0,0 +1,22 @@
+namespace DevantlerTech.KubernetesGenerator.Native.Models;
+
+/// <summary>
+/// Represents the target resource reference for HorizontalPodAutoscaler.
+/// </summary>
+public class HorizontalPodAutoscalerScaleTargetRef
+{
+  /// <summary>
+  /// Gets or sets the API version of the target resource.
+  /// </summary>
+  public string ApiVersion { get; set; } = "apps/v1";
+
+  /// <summary>
+  /// Gets or sets the kind of the target resource.
+  /// </summary>
+  public required HorizontalPodAutoscalerTargetKind Kind { get; set; }
+
+  /// <summary>
+  /// Gets or sets the name of the target resource.
+  /// </summary>
+  public required string Name { get; set; }
+}

src/DevantlerTech.KubernetesGenerator.Native/Models/HorizontalPodAutoscalerSpec.cs

@@ -0,0 +1,23 @@
+namespace DevantlerTech.KubernetesGenerator.Native.Models;
+
+/// <summary>
+/// Represents the specification for a HorizontalPodAutoscaler using kubectl autoscale.
+/// </summary>
+public class HorizontalPodAutoscalerSpec
+{
+  /// <summary>
+  /// Gets or sets the target resource reference.
+  /// </summary>
+  public required HorizontalPodAutoscalerScaleTargetRef ScaleTargetRef { get; set; }
+
+  /// <summary>
+  /// Gets or sets the minimum number of replicas.
+  /// If null or negative, kubectl will apply a default value.
+  /// </summary>
+  public int? MinReplicas { get; set; }
+
+  /// <summary>
+  /// Gets or sets the maximum number of replicas. This is required.
+  /// </summary>
+  public required int MaxReplicas { get; set; }
+}

src/DevantlerTech.KubernetesGenerator.Native/Models/HorizontalPodAutoscalerTargetKind.cs

@@ -0,0 +1,27 @@
+namespace DevantlerTech.KubernetesGenerator.Native.Models;
+
+/// <summary>
+/// Represents the valid resource kinds that can be targeted by HorizontalPodAutoscaler.
+/// </summary>
+public enum HorizontalPodAutoscalerTargetKind
+{
+  /// <summary>
+  /// Deployment resource.
+  /// </summary>
+  Deployment,
+
+  /// <summary>
+  /// ReplicaSet resource.
+  /// </summary>
+  ReplicaSet,
+
+  /// <summary>
+  /// StatefulSet resource.
+  /// </summary>
+  StatefulSet,
+
+  /// <summary>
+  /// ReplicationController resource.
+  /// </summary>
+  ReplicationController
+}

tests/DevantlerTech.KubernetesGenerator.Native.Tests/HorizontalPodAutoscalerGeneratorTests/GenerateAsyncTests.cs

@@ -1,4 +1,4 @@
-using k8s.Models;
+using DevantlerTech.KubernetesGenerator.Native.Models;
 
 namespace DevantlerTech.KubernetesGenerator.Native.Tests.HorizontalPodAutoscalerGeneratorTests;
 
@@ -9,33 +9,30 @@ namespace DevantlerTech.KubernetesGenerator.Native.Tests.HorizontalPodAutoscaler
 public sealed class GenerateAsyncTests
 {
   /// <summary>
-  /// Verifies the generated HorizontalPodAutoscaler object.
+  /// Verifies the generated HorizontalPodAutoscaler object with full configuration.
   /// </summary>
   /// <returns></returns>
   [Fact]
-  public async Task GenerateAsync_WithAllPropertiesSet_ShouldGenerateAValidHorizontalPodAutoscaler()
+  public async Task GenerateAsync_WithFullConfiguration_ShouldGenerateAValidHorizontalPodAutoscaler()
   {
     // Arrange
     var generator = new HorizontalPodAutoscalerGenerator();
-    var model = new V2HorizontalPodAutoscaler
+    var model = new HorizontalPodAutoscaler
     {
-      ApiVersion = "autoscaling/v2",
-      Kind = "HorizontalPodAutoscaler",
-      Metadata = new V1ObjectMeta
+      Metadata = new Metadata
       {
         Name = "horizontal-pod-autoscaler",
-        NamespaceProperty = "default"
+        Namespace = "default"
       },
-      Spec = new V2HorizontalPodAutoscalerSpec
+      Spec = new HorizontalPodAutoscalerSpec
       {
-        ScaleTargetRef = new V2CrossVersionObjectReference
+        ScaleTargetRef = new HorizontalPodAutoscalerScaleTargetRef
         {
-          ApiVersion = "apps/v1",
-          Kind = "Deployment",
+          Kind = HorizontalPodAutoscalerTargetKind.Deployment,
           Name = "deployment-name"
         },
         MinReplicas = 1,
-        MaxReplicas = 10,
+        MaxReplicas = 10
       }
     };
 
@@ -53,5 +50,46 @@ public async Task GenerateAsync_WithAllPropertiesSet_ShouldGenerateAValidHorizon
     // Cleanup
     File.Delete(outputPath);
   }
+
+  /// <summary>
+  /// Verifies the generated HorizontalPodAutoscaler object with minimal required properties.
+  /// </summary>
+  /// <returns></returns>
+  [Fact]
+  public async Task GenerateAsync_WithMinimalConfiguration_ShouldGenerateAValidHorizontalPodAutoscaler()
+  {
+    // Arrange
+    var generator = new HorizontalPodAutoscalerGenerator();
+    var model = new HorizontalPodAutoscaler
+    {
+      Metadata = new Metadata
+      {
+        Name = "minimal-hpa"
+      },
+      Spec = new HorizontalPodAutoscalerSpec
+      {
+        ScaleTargetRef = new HorizontalPodAutoscalerScaleTargetRef
+        {
+          Kind = HorizontalPodAutoscalerTargetKind.ReplicaSet,
+          Name = "replicaset-name"
+        },
+        MaxReplicas = 5
+      }
+    };
+
+    // Act
+    string fileName = "minimal-hpa.yaml";
+    string outputPath = Path.Combine(Path.GetTempPath(), fileName);
+    if (File.Exists(outputPath))
+      File.Delete(outputPath);
+    await generator.GenerateAsync(model, outputPath);
+    string fileContent = await File.ReadAllTextAsync(outputPath);
+
+    // Assert
+    _ = await Verify(fileContent, extension: "yaml").UseFileName(fileName);
+
+    // Cleanup
+    File.Delete(outputPath);
+  }
 }
 

tests/DevantlerTech.KubernetesGenerator.Native.Tests/HorizontalPodAutoscalerGeneratorTests/horizontal-pod-autoscaler.yaml.verified.yaml

@@ -1,13 +1,13 @@
----
+---
 apiVersion: autoscaling/v2
 kind: HorizontalPodAutoscaler
 metadata:
-  name: horizontal-pod-autoscaler
   namespace: default
+  name: horizontal-pod-autoscaler
 spec:
-  maxReplicas: 10
-  minReplicas: 1
   scaleTargetRef:
     apiVersion: apps/v1
     kind: Deployment
     name: deployment-name
+  minReplicas: 1
+  maxReplicas: 10

tests/DevantlerTech.KubernetesGenerator.Native.Tests/HorizontalPodAutoscalerGeneratorTests/minimal-hpa.yaml.verified.yaml

@@ -0,0 +1,11 @@
+---
+apiVersion: autoscaling/v2
+kind: HorizontalPodAutoscaler
+metadata:
+  name: minimal-hpa
+spec:
+  scaleTargetRef:
+    apiVersion: apps/v1
+    kind: ReplicaSet
+    name: replicaset-name
+  maxReplicas: 5