Fixed bug (wrong method handle in service provider)

Added more tests

Author: VeryStrongFingers

README.md

@@ -161,8 +161,7 @@ class MyConsoleApp extends Command
 # Light footprint
 
 - **Zero external dependencies** outside of Laravel contracts
-- No external dependencies
-- No memory leakage (Not yet proven)
+- No memory leakage (_needs validation/tests_)
     - One time use console logger is attached & detached alongside command execution
     - All references destroyed after command termination _(letting PHP Garbage Collection do its thing)_
 - Service Provider lazily works only when running in console mode

src/Providers/ConsoleLoggServiceProvider.php

@@ -55,8 +55,8 @@ public function register()
             LogManager::class,
             Closure::fromCallable(
                 [
-                    $this->app->make(LogManagerResolverListener::class),
-                    'resolve'
+                    $this->app->make(LogManagerResolverListenerInterface::class),
+                    'handle'
                 ]
             )
         );

tests/Doubles/Fakes/vendor/Illuminate/ApplicationFake.php

@@ -6,10 +6,15 @@
 
 use ArrayObject;
 use Closure;
+use DevThis\ConsoleLogg\Interfaces\Listener\LogManagerResolverListenerInterface;
+use DevThis\ConsoleLogg\Listeners\LogManagerResolverListener;
 use Illuminate\Contracts\Foundation\Application;
+use Tests\Doubles\Spies\Binder\LogOutputBinderFake;
 
 class ApplicationFake extends ArrayObject implements Application
 {
+    private $registered = [];
+
     public function __construct(?array $array = null)
     {
         parent::__construct($array ?? []);
@@ -114,6 +119,7 @@ public function flush()
 
     public function get($id)
     {
+        return $this->registered[$id] ?? $id;
     }
 
     public function getCachedConfigPath()
@@ -170,6 +176,9 @@ public function loadEnvironmentFrom($file)
 
     public function make($abstract, array $parameters = [])
     {
+        if ($abstract === LogManagerResolverListenerInterface::class) {
+            return new LogManagerResolverListener(new EventDispatcherFake(), new LogOutputBinderFake());
+        }
     }
 
     public function register($provider, $force = false)
@@ -222,6 +231,7 @@ public function shouldSkipMiddleware()
 
     public function singleton($abstract, $concrete = null)
     {
+        $this->registered[$abstract] = $concrete ?? $abstract;
     }
 
     public function singletonIf($abstract, $concrete = null)

tests/Unit/Providers/ConsoleLoggServiceProviderTest.php

@@ -4,6 +4,12 @@
 
 namespace Tests\Unit\Providers;
 
+use DevThis\ConsoleLogg\Binder\LogOutputBinder;
+use DevThis\ConsoleLogg\Factories\FilterableConsoleLoggerFactory;
+use DevThis\ConsoleLogg\Interfaces\Binder\LogOutputBindedInterface;
+use DevThis\ConsoleLogg\Interfaces\Factories\FilterableConsoleLoggerFactoryInterface;
+use DevThis\ConsoleLogg\Interfaces\Listener\LogManagerResolverListenerInterface;
+use DevThis\ConsoleLogg\Listeners\LogManagerResolverListener;
 use DevThis\ConsoleLogg\Providers\ConsoleLoggServiceProvider;
 use PHPUnit\Framework\TestCase;
 use ReflectionClass;
@@ -24,7 +30,7 @@ public function testPublishedPath(): void
         $app = new ApplicationFake();
         // if we don't use reflection to determine file location we would need fuzzy asserting
         $reflection = new ReflectionClass(ConsoleLoggServiceProvider::class);
-        $s = new ConsoleLoggServiceProvider($app);
+        $serviceProvider = new ConsoleLoggServiceProvider($app);
         $expectedPublishedPathsBefore = [];
         $actualPublishedPathsBefore = ConsoleLoggServiceProvider::pathsToPublish();
         $expectedPublishedPaths = [
@@ -35,10 +41,25 @@ public function testPublishedPath(): void
             ) => '%APP%/' . 'console-logg.php'
         ];
 
-        $s->boot();
+        $serviceProvider->boot();
         $publishedPaths = ConsoleLoggServiceProvider::pathsToPublish();
 
         self::assertSame($expectedPublishedPaths, $publishedPaths);
         self::assertSame($expectedPublishedPathsBefore, $actualPublishedPathsBefore);
     }
+
+    public function testRegisterBindings(): void
+    {
+        $app = new ApplicationFake();
+        $serviceProvider = new ConsoleLoggServiceProvider($app);
+
+        $serviceProvider->register();
+
+        self::assertSame(LogOutputBinder::class, $app->get(LogOutputBindedInterface::class));
+        self::assertSame(LogManagerResolverListener::class, $app->get(LogManagerResolverListenerInterface::class));
+        self::assertSame(
+            FilterableConsoleLoggerFactory::class,
+            $app->get(FilterableConsoleLoggerFactoryInterface::class)
+        );
+    }
 }