update tests : code refactoring + make them clean

Author: dev-javascript

src/index.test.js

@@ -472,13 +472,43 @@ describe('ready function : ', () => {
     expect(op.onChange.mock.calls.length).toBe(0);
   });
 });
-describe('initial events : ', () => {
-  test('onLoad and then onInit are called initially but onChange is not called', () => {
+describe('onLoad callback : ', () => {
+  test('onLoad callback should be called once time initially without any parameters', () => {
     renderApp();
     expect(op.onLoad.mock.calls.length).toBe(1);
+    expect(op.onLoad.mock.calls[0].length).toBe(0);
+    act(() => {
+      instance.select('3');
+      instance.close('1');
+      instance.open({id: '3'});
+      instance.refresh();
+    });
+    expect(op.onLoad.mock.calls.length).toBe(1);
+  });
+  test('checking context of onLoad callback', () => {
+    expect.assertions(2);
+    op.onLoad = jest.fn(function () {
+      expect(Object.prototype.toString.call(this)).toBe('[object Object]');
+      expect(this.hasOwnProperty('getData')).toBe(true);
+    });
+    renderApp();
+    op.onLoad = function () {};
+  });
+});
+describe('onInit callback : ', () => {
+  test('onInit callback should be called initially without any parameters', () => {
+    renderApp();
     expect(op.onInit.mock.calls.length).toBe(1);
-    expect(op.onChange.mock.calls.length).toBe(0);
-    expect(op.onLoad).toHaveBeenCalledBefore(op.onInit);
+    expect(op.onInit.mock.calls[0].length).toBe(0);
+  });
+  test('checking context of onInit callback', () => {
+    expect.assertions(2);
+    op.onInit = jest.fn(function () {
+      expect(Object.prototype.toString.call(this)).toBe('[object Object]');
+      expect(this.hasOwnProperty('getData')).toBe(true);
+    });
+    renderApp();
+    op.onInit = function () {};
   });
 });
 describe('onChange callback : ', () => {
@@ -499,6 +529,74 @@ describe('onChange callback : ', () => {
     expect(op.onChange.mock.calls[0][0].currentData).toEqual(instance.getData());
     expect(op.onChange.mock.calls[0][0].previousData).toEqual(instance.getPreviousData());
   });
+  test('it is not called initially', () => {
+    renderApp();
+    expect(op.onChange.mock.calls.length).toBe(0);
+  });
+  test('onChange parameters should be immutable', () => {
+    renderApp();
+    const onChange1 = jest.fn(({currentData, previousData, closedTabIDs, openedTabIDs}) => {
+      closedTabIDs.push('6');
+      openedTabIDs.push('6');
+      currentData.selectedTabID = '6';
+      previousData.selectedTabID = '6';
+    });
+    const onChange2 = jest.fn(({currentData, previousData, closedTabIDs, openedTabIDs}) => {
+      closedTabIDs.push('7');
+      openedTabIDs.push('7');
+      currentData.selectedTabID = '7';
+      previousData.selectedTabID = '7';
+    });
+    const onOpen = jest.fn(() => {});
+    const onClose = jest.fn(() => {});
+    const onSelect = jest.fn(() => {});
+    const onFirstSelect = jest.fn(() => {});
+    act(() => {
+      instance.setOption('onChange', ({currentData, previousData, closedTabIDs, openedTabIDs}) => {
+        closedTabIDs.push('5');
+        openedTabIDs.push('5');
+        currentData.selectedTabID = '5';
+        previousData.selectedTabID = '5';
+      });
+      instance.one('onChange', onChange1);
+      instance.on('onChange', onChange2);
+      instance.on('onOpen', onOpen);
+      instance.on('onClose', onClose);
+      instance.on('onSelect', onSelect);
+      instance.on('onFirstSelect', onFirstSelect);
+      instance.close('2');
+      instance.open({id: '3'});
+      instance.select('3');
+    });
+
+    expect(onSelect.mock.calls[0][0]).toEqual({
+      currentSelectedTabId: '3',
+      perviousSelectedTabId: '1',
+      previousSelectedTabId: '1',
+    });
+    expect(onFirstSelect.mock.calls[0][0]).toEqual({
+      currentSelectedTabId: '3',
+      previousSelectedTabId: '1',
+    });
+    expect(onClose.mock.calls[0][0]).toEqual(['2']);
+    expect(onOpen.mock.calls[0][0]).toEqual(['3']);
+    expect(onChange2.mock.calls[0][0]).toEqual({
+      currentData: {selectedTabID: '3', openTabIDs: ['1', '3']},
+      previousData: {selectedTabID: '1', openTabIDs: ['1', '2']},
+      perviousData: {selectedTabID: '1', openTabIDs: ['1', '2']},
+      closedTabIDs: ['2'],
+      openedTabIDs: ['3'],
+    });
+  });
+  test('checking context of onChange callback', () => {
+    expect.assertions(2);
+    op.onChange = jest.fn(function () {
+      expect(Object.prototype.toString.call(this)).toBe('[object Object]');
+      expect(this.hasOwnProperty('getData')).toBe(true);
+    });
+    renderApp();
+    op.onChange = function () {};
+  });
 });
 describe('onSelect callback : ', () => {
   test('onSelect is called with {currentSelectedTabId,previousSelectedTabId,perviousSelectedTabId} object as a parameter', () => {
@@ -513,6 +611,41 @@ describe('onSelect callback : ', () => {
       previousSelectedTabId: '1',
     });
   });
+  test('it is not called initially', () => {
+    renderApp();
+    expect(op.onSelect.mock.calls.length).toBe(0);
+  });
+  test('onSelect parameters should be immutable', () => {
+    renderApp();
+    const onSelect1 = jest.fn((param) => {
+      param.previousSelectedTabId = 19;
+    });
+    const onSelect2 = jest.fn((param) => {
+      param.previousSelectedTabId = 20;
+    });
+    act(() => {
+      instance.setOption('onSelect', (param) => {
+        param.currentSelectedTabId = 10;
+      });
+      instance.on('onSelect', onSelect1);
+      instance.on('onSelect', onSelect2);
+      instance.select('2');
+    });
+    expect(onSelect2.mock.calls[0][0]).toEqual({
+      currentSelectedTabId: '2',
+      perviousSelectedTabId: '1',
+      previousSelectedTabId: '1',
+    });
+  });
+  test('checking context of onSelect callback', () => {
+    expect.assertions(2);
+    op.onSelect = jest.fn(function () {
+      expect(Object.prototype.toString.call(this)).toBe('[object Object]');
+      expect(this.hasOwnProperty('getData')).toBe(true);
+    });
+    renderApp();
+    op.onSelect = function () {};
+  });
 });
 describe('onFirstSelect callback : ', () => {
   test('it is not triggered initially', () => {
@@ -548,30 +681,6 @@ describe('onFirstSelect callback : ', () => {
       previousSelectedTabId: '1',
     });
   });
-});
-describe('callbacks should be called with immutable parameters : ', () => {
-  test('onSelect parameters should be immutable', () => {
-    renderApp();
-    const onSelect1 = jest.fn((param) => {
-      param.previousSelectedTabId = 19;
-    });
-    const onSelect2 = jest.fn((param) => {
-      param.previousSelectedTabId = 20;
-    });
-    act(() => {
-      instance.setOption('onSelect', (param) => {
-        param.currentSelectedTabId = 10;
-      });
-      instance.on('onSelect', onSelect1);
-      instance.on('onSelect', onSelect2);
-      instance.select('2');
-    });
-    expect(onSelect2.mock.calls[0][0]).toEqual({
-      currentSelectedTabId: '2',
-      perviousSelectedTabId: '1',
-      previousSelectedTabId: '1',
-    });
-  });
   test('onFirstSelect parameters should be immutable', () => {
     renderApp();
     const onFirstSelect1 = jest.fn((param) => {
@@ -593,6 +702,29 @@ describe('callbacks should be called with immutable parameters : ', () => {
       previousSelectedTabId: '1',
     });
   });
+  test('checking context of onFirstSelect callback', () => {
+    expect.assertions(2);
+    op.onFirstSelect = jest.fn(function () {
+      expect(Object.prototype.toString.call(this)).toBe('[object Object]');
+      expect(this.hasOwnProperty('getData')).toBe(true);
+    });
+    renderApp();
+    op.onFirstSelect = function () {};
+  });
+});
+describe('onOpen callback : ', () => {
+  test('checking onOpen parameters', () => {
+    renderApp();
+    act(() => {
+      instance.open({id: '3'});
+    });
+    expect(op.onOpen.mock.calls.length).toBe(1);
+    expect(op.onOpen.mock.calls[0][0]).toEqual(['3']);
+  });
+  test('it is not called initially', () => {
+    renderApp();
+    expect(op.onOpen.mock.calls.length).toBe(0);
+  });
   test('onOpen parameters should be immutable', () => {
     renderApp();
     const onOpen1 = jest.fn((openedTabIDs) => {
@@ -611,6 +743,29 @@ describe('callbacks should be called with immutable parameters : ', () => {
     });
     expect(onOpen2.mock.calls[0][0]).toEqual(['3']);
   });
+  test('checking context of onOpen callback', () => {
+    expect.assertions(2);
+    op.onOpen = jest.fn(function () {
+      expect(Object.prototype.toString.call(this)).toBe('[object Object]');
+      expect(this.hasOwnProperty('getData')).toBe(true);
+    });
+    renderApp();
+    op.onOpen = function () {};
+  });
+});
+describe('onClose callback : ', () => {
+  test('checking onClose parameters', () => {
+    renderApp();
+    act(() => {
+      instance.close('2');
+    });
+    expect(op.onClose.mock.calls.length).toBe(1);
+    expect(op.onClose.mock.calls[0][0]).toEqual(['2']);
+  });
+  test('it is not called initially', () => {
+    renderApp();
+    expect(op.onClose.mock.calls.length).toBe(0);
+  });
   test('onClose parameters should be immutable', () => {
     renderApp();
     const onClose1 = jest.fn((closedTabIDs) => {
@@ -629,59 +784,13 @@ describe('callbacks should be called with immutable parameters : ', () => {
     });
     expect(onClose2.mock.calls[0][0]).toEqual(['2']);
   });
-  test('onChange parameters should be immutable', () => {
-    renderApp();
-    const onChange1 = jest.fn(({currentData, previousData, closedTabIDs, openedTabIDs}) => {
-      closedTabIDs.push('6');
-      openedTabIDs.push('6');
-      currentData.selectedTabID = '6';
-      previousData.selectedTabID = '6';
-    });
-    const onChange2 = jest.fn(({currentData, previousData, closedTabIDs, openedTabIDs}) => {
-      closedTabIDs.push('7');
-      openedTabIDs.push('7');
-      currentData.selectedTabID = '7';
-      previousData.selectedTabID = '7';
-    });
-    const onOpen = jest.fn(() => {});
-    const onClose = jest.fn(() => {});
-    const onSelect = jest.fn(() => {});
-    const onFirstSelect = jest.fn(() => {});
-    act(() => {
-      instance.setOption('onChange', ({currentData, previousData, closedTabIDs, openedTabIDs}) => {
-        closedTabIDs.push('5');
-        openedTabIDs.push('5');
-        currentData.selectedTabID = '5';
-        previousData.selectedTabID = '5';
-      });
-      instance.one('onChange', onChange1);
-      instance.on('onChange', onChange2);
-      instance.on('onOpen', onOpen);
-      instance.on('onClose', onClose);
-      instance.on('onSelect', onSelect);
-      instance.on('onFirstSelect', onFirstSelect);
-      instance.close('2');
-      instance.open({id: '3'});
-      instance.select('3');
-    });
-
-    expect(onSelect.mock.calls[0][0]).toEqual({
-      currentSelectedTabId: '3',
-      perviousSelectedTabId: '1',
-      previousSelectedTabId: '1',
-    });
-    expect(onFirstSelect.mock.calls[0][0]).toEqual({
-      currentSelectedTabId: '3',
-      previousSelectedTabId: '1',
-    });
-    expect(onClose.mock.calls[0][0]).toEqual(['2']);
-    expect(onOpen.mock.calls[0][0]).toEqual(['3']);
-    expect(onChange2.mock.calls[0][0]).toEqual({
-      currentData: {selectedTabID: '3', openTabIDs: ['1', '3']},
-      previousData: {selectedTabID: '1', openTabIDs: ['1', '2']},
-      perviousData: {selectedTabID: '1', openTabIDs: ['1', '2']},
-      closedTabIDs: ['2'],
-      openedTabIDs: ['3'],
+  test('checking context of onClose callback', () => {
+    expect.assertions(2);
+    op.onClose = jest.fn(function () {
+      expect(Object.prototype.toString.call(this)).toBe('[object Object]');
+      expect(this.hasOwnProperty('getData')).toBe(true);
     });
+    renderApp();
+    op.onClose = function () {};
   });
 });

src/useDynamicTabs/useDynamicTabs.test.js

@@ -76,7 +76,7 @@ afterAll(() => {
   document.body.removeChild(container);
   container = null;
 });
-describe('checking number of tabs renders : ', () => {
+describe('counting tabs renders : ', () => {
   test('each tab should be rendered once initially', () => {
     let _api;
     const getApiInstance = function (op) {
@@ -288,7 +288,7 @@ describe('checking number of tabs renders : ', () => {
     expect(_api.optionsManager.setting.panelIdTemplate.mock.calls.length).toBe(3);
   });
 });
-describe('checking number of panels renders : ', () => {
+describe('counting panels renders : ', () => {
   test('each panel should be rendered once initially', () => {
     let _api;
     const getApiInstance = function (op) {