-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate caddyfile #89
base: main
Are you sure you want to change the base?
Conversation
@tijno any thoughts on this change? Seems safe and clearly better to me |
i can review in the morning - keeping caddyfiles in sync has been an issue in the past so reducing duppl files seems sensible. am on mobile and want to look at impact on node setup. will confirm in the morning |
Thanks! No rush |
I think there are 2 issues that will break things
Besides that there are a bunch of other differences between the two caddy files - that are worth checking whether if changing them would break setups. However - many of these may be legacy and no longer required. Maybe you could cast your eye over them and let me know. Here is full list of the differences. main Caddy section
connect-src
script-src
style-src
frame-src
Other
|
This is not necessary because the frontend caddyfile has
self
and we no longer recommend theapi.domain.com
configuration by default.