update errors fixed

Author: claudemyburgh

phpstan-baseline.neon

@@ -0,0 +1 @@
+

phpstan.neon.dist

@@ -10,3 +10,5 @@ parameters:
     tmpDir: build/phpstan
     checkOctaneCompatibility: true
     checkModelProperties: true
+
+

src/Brevo.php

@@ -22,6 +22,9 @@ public function __construct(?ContactsApi $contactsApi = null)
         $this->contactsApi = $contactsApi ?? $this->createDefaultContactsApi();
     }
 
+    /**
+     * @return \Brevo\Client\Api\ContactsApi
+     */
     private function createDefaultContactsApi(): ContactsApi
     {
         $config = Configuration::getDefaultConfiguration()
@@ -30,11 +33,21 @@ private function createDefaultContactsApi(): ContactsApi
         return new ContactsApi(new Client, $config);
     }
 
+    /**
+     * @param \Brevo\Client\Api\ContactsApi $contactsApi
+     *
+     * @return void
+     */
     public function setContactsApi(ContactsApi $contactsApi): void
     {
         $this->contactsApi = $contactsApi;
     }
 
+    /**
+     * @param string $email
+     *
+     * @return \Brevo\Client\Model\GetExtendedContactDetails|null
+     */
     public function getContactInfo(string $email): ?GetExtendedContactDetails
     {
         try {
@@ -46,7 +59,14 @@ public function getContactInfo(string $email): ?GetExtendedContactDetails
         }
     }
 
-    public function subscribe(string $email, string $listId, array $attributes = []): bool
+    /**
+     * @param string $email
+     * @param integer $listId
+     * @param array $attributes
+     *
+     * @return bool
+     */
+    public function subscribe(string $email, int $listId, array $attributes = []): bool
     {
         try {
             // Check if contact exists
@@ -76,7 +96,7 @@ public function subscribe(string $email, string $listId, array $attributes = [])
             // Subscribe to list
             $addContactToList = new AddContactToList;
             $addContactToList->setEmails([$email]);
-            $this->contactsApi->addContactToList($listId, $addContactToList);
+            $this->contactsApi->addContactToList( $listId, $addContactToList);
 
             return true;
         } catch (ApiException $e) {
@@ -86,7 +106,13 @@ public function subscribe(string $email, string $listId, array $attributes = [])
         }
     }
 
-    public function unsubscribe(string $email, string $listId): bool
+    /**
+     * @param string $email
+     * @param integer $listId
+     *
+     * @return bool
+     */
+    public function unsubscribe(string $email, int $listId): bool
     {
         try {
             $this->removeContactFromList($email, $listId);
@@ -103,14 +129,13 @@ public function unsubscribe(string $email, string $listId): bool
     /**
      * @throws \Brevo\Client\ApiException
      */
-    private function createOrUpdateContact(string $email, array $attributes): void
+    public function createOrUpdateContact(string $email, array $attributes): void
     {
         try {
             $this->updateExistingContact($email, $attributes);
         } catch (ApiException $e) {
             if ($e->getCode() === 404) {
                 $this->createNewContact($email, $attributes);
-
                 return;
             }
             throw $e;
@@ -134,7 +159,7 @@ private function updateExistingContact(string $email, array $attributes): void
     /**
      * @throws \Brevo\Client\ApiException
      */
-    private function createNewContact(string $email, array $attributes): void
+    public function createNewContact(string $email, array $attributes): void
     {
         $createContact = new CreateContact;
         $createContact->setEmail($email);
@@ -149,23 +174,30 @@ private function createNewContact(string $email, array $attributes): void
     /**
      * @throws \Brevo\Client\ApiException
      */
-    private function addContactToList(string $email, string $listId): void
+    public function addContactToList(string $email, int $listId): void
     {
-        $listRequest = new AddContactToList;
+        $listRequest = new AddContactToList();
         $listRequest->setEmails([$email]);
         $this->contactsApi->addContactToList($listId, $listRequest);
     }
 
     /**
      * @throws \Brevo\Client\ApiException
      */
-    private function removeContactFromList(string $email, string $listId): void
+    private function removeContactFromList(string $email, int $listId): void
     {
         $listRequest = new RemoveContactFromList;
         $listRequest->setEmails([$email]);
         $this->contactsApi->removeContactFromList($listId, $listRequest);
     }
 
+    /**
+     * @param \Brevo\Client\ApiException $e
+     * @param string $context
+     * @param bool $isWarning
+     *
+     * @return void
+     */
     private function handleApiException(ApiException $e, string $context, bool $isWarning = false): void
     {
         $logMethod = $isWarning ? 'warning' : 'error';

tests/BrevoNewsletterTest.php

@@ -47,7 +47,7 @@
 
 test('subscribes new contact with attributes', function () {
     $email = '[email protected]';
-    $listId = 'list-123';
+    $listId = 144;
     $attributes = ['name' => 'John Doe'];
 
     // Mock the initial contact check (contact doesn't exist)
@@ -82,7 +82,7 @@
 
 test('updates existing contact and subscribes', function () {
     $email = '[email protected]';
-    $listId = 'list-456';
+    $listId = 456;
     $attributes = ['name' => 'Updated Name'];
 
     // Mock the initial contact check (contact exists)
@@ -120,14 +120,14 @@
 
     Log::shouldReceive('error')->once();
 
-    $result = $this->brevo->subscribe('[email protected]', 'list-123');
+    $result = $this->brevo->subscribe('[email protected]', 144);
 
     expect($result)->toBeFalse();
 });
 
 test('unsubscribes contact successfully', function () {
     $email = '[email protected]';
-    $listId = 'list-789';
+    $listId = 789;
 
     $this->contactsApi->shouldReceive('removeContactFromList')
         ->once()
@@ -146,7 +146,7 @@
 
     Log::shouldReceive('warning')->once();
 
-    $result = $this->brevo->unsubscribe('[email protected]', 'list-123');
+    $result = $this->brevo->unsubscribe('[email protected]', 144);
 
     expect($result)->toBeTrue();
 });
@@ -157,11 +157,13 @@
 
     Log::shouldReceive('error')->once();
 
-    $result = $this->brevo->unsubscribe('[email protected]', 'list-123');
+    $result = $this->brevo->unsubscribe('[email protected]', 144);
 
     expect($result)->toBeFalse();
 });
 
+
+
 afterEach(function () {
     Mockery::close();
 });