We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is inefficient. The unit test could maybe use ES6 Array.prototype.observe.
Array.prototype.observe
The text was updated successfully, but these errors were encountered:
Why not just return at if (i>=0)?
if (i>=0)
So this..
if (i >= 0) this.data.splice(i, 1); // delete
becomes this..
if (i >= 0) return this;
(or if my pull request is merged, if (i >= 0) return;)
if (i >= 0) return;
Sorry, something went wrong.
@brianshaler
This doesn't work. The passed value (entry) needs to be lower than the lowest value (this.data[this.data.length - 1]).
entry
this.data[this.data.length - 1]
No branches or pull requests
This is inefficient. The unit test could maybe use ES6
Array.prototype.observe
.The text was updated successfully, but these errors were encountered: