Qt5 compatibility #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 13, 2015 14:32
- sample application not being built any more
- Qt5 compatibility specify "-D USE_Qt5=ON" when building, in addition to "-D Qt5Core_DIR=..." - added CMake find file, which allows for CuteLogger to be found using "FIND_PACKAGE(CuteLogger CONFIG REQUIRED)" (NB: "make install" will install to e.g. /usr/local/include/cutelogger/ and /usr/local/lib/cutelogger/ now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've added some CMake configuration options to make CuteLogger compatible with Qt5 as well, while keeping Qt4 as the default. As such, to use Qt5, specify
-D USE_Qt5=ONwhen building.I've also added a CMake find file and install options that allow for
-D CuteLogger_DIR=/path/to/CuteLoggerConfig.cmaketo be used when building other projects that depend on CuteLogger. Nowmake installinstalls to${CMAKE_INSTALL_PREFIX}/include/cutelogger/and${CMAKE_INSTALL_PREFIX}/lib/cutelogger/Thanks for this nice library. I'm using it for thread-safe logging to the console and file.
Cheers,
Dzhoshkun