slip

Author: TomasVotruba

.github/workflows/code_analysis.yml

@@ -14,7 +14,7 @@ jobs:
           - name: Setup PHP
             uses: shivammathur/setup-php@v2
             with:
-              php-version: 8.0
+              php-version: 8.1
 
           - name: Validate composer
             run: composer validate

.gitignore

@@ -6,4 +6,4 @@
 composer.lock
 
 # tests
-.phpunit.result
+.phpunit.result.cache

.phpunit.result.cache

@@ -25,7 +25,7 @@
         },
         "classmap": [
             "stubs",
-            "tests/Feature/classes"
+            "tests/Source"
         ]
     },
     "extra": {

composer.json

@@ -43,6 +43,11 @@ services:
         tags:
             - phpstan.broker.methodsClassReflectionExtension
 
+    -
+        class: PHPStanCakePHP2\ReturnTypeExtension\LoadComponentOnFlyMethodReturnTypeExtension
+        tags:
+            - phpstan.broker.dynamicMethodReturnTypeExtension
+
     -
         class: PHPStanCakePHP2\Service\SchemaService
         arguments:

config/extension.neon

@@ -0,0 +1,55 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PHPStanCakePHP2\ReturnTypeExtension;
+
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Scalar\String_;
+use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\MethodReflection;
+use PHPStan\Reflection\ReflectionProvider;
+use PHPStan\Type\DynamicMethodReturnTypeExtension;
+use PHPStan\Type\ObjectType;
+use PHPStan\Type\Type;
+
+final class LoadComponentOnFlyMethodReturnTypeExtension implements DynamicMethodReturnTypeExtension
+{
+    private ReflectionProvider $reflectionProvider;
+
+    public function __construct(ReflectionProvider $reflectionProvider)
+    {
+        $this->reflectionProvider = $reflectionProvider;
+    }
+
+    public function getClass(): string
+    {
+        return 'ComponentCollection';
+    }
+
+    public function isMethodSupported(MethodReflection $methodReflection): bool
+    {
+        return $methodReflection->getName() === 'load';
+    }
+
+    public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): ?Type
+    {
+        $arg = $methodCall->getArgs()[0]->value;
+
+        if (!$arg instanceof String_) {
+            return null;
+        }
+
+        $componentName = $arg->value . 'Component';
+
+        if (!$this->reflectionProvider->hasClass($componentName)) {
+            return null;
+        }
+
+        if (!$this->reflectionProvider->getClass($componentName)->is('Component')) {
+            return null;
+        }
+
+        return new ObjectType($componentName);
+    }
+}

src/ReturnTypeExtension/LoadComponentOnFlyMethodReturnTypeExtension.php

@@ -24,6 +24,10 @@ public static function dataFileAsserts(): Iterator
     {
         yield from self::gatherAssertTypes(__DIR__ . '/Fixture/existing_component_component.php');
         yield from self::gatherAssertTypes(__DIR__ . '/Fixture/invalid_component_property.php');
+
+        yield from self::gatherAssertTypes(__DIR__ . '/Fixture/existing_controller_component.php');
+        yield from self::gatherAssertTypes(__DIR__ . '/Fixture/existing_controller_component_from_parent_controller.php');
+        yield from self::gatherAssertTypes(__DIR__ . '/Fixture/existing_controller_component_with_same_method_name_as_model.php');
     }
 
     public static function getAdditionalConfigFiles(): array

tests/ClassPropertyExtension/ClassComponentPropertyExtension/ClassComponentPropertyExtensionTest.php

@@ -2,6 +2,7 @@
 
 declare(strict_types = 1);
 
+use PHPStanCakePHP2\Tests\Source\Controller\Component\BasicComponent;
 use function PHPStan\Testing\assertType;
 
 /** @var BasicComponent $parentComponent */

tests/ClassPropertyExtension/ClassComponentPropertyExtension/Fixture/existing_component_component.php

@@ -2,6 +2,7 @@
 
 declare(strict_types = 1);
 
+use PHPStanCakePHP2\Tests\Source\Controller\BasicController;
 use function PHPStan\Testing\assertType;
 
 /** @var BasicController $controller */

tests/Feature/data/existing_controller_component.php renamed to tests/ClassPropertyExtension/ClassComponentPropertyExtension/Fixture/existing_controller_component.php

@@ -2,6 +2,7 @@
 
 declare(strict_types = 1);
 
+use PHPStanCakePHP2\Tests\Source\Controller\SameAsModelController;
 use function PHPStan\Testing\assertType;
 
 /** @var SameAsModelController $controller */