Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the test database after each test run #900

Closed
7 tasks
trevor2718 opened this issue Oct 20, 2022 · 5 comments
Closed
7 tasks

Delete the test database after each test run #900

trevor2718 opened this issue Oct 20, 2022 · 5 comments

Comments

@trevor2718
Copy link

trevor2718 commented Oct 20, 2022

User Story - Business Need

  • Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)

As a Notify developer,
I want to properly delete the test DB after each test run
So that previous runs cannot affect the current run.

Additional Info and Resources

TODO: properly delete the database after all workers finish?

Engineering Checklist

  • At the above TODO, run a query to delete the test database.
  • See if Pytest can take a flag for not deleting the tests database. If so, use that flag to make the above action condition.

Acceptance Criteria

  • No significant slow down of unit tests noted
  • After running unit tests, the test database is removed (verify on your local database container).
  • The TODO comment is removed.
  • If implemented, the Pytest flag works.
@mjones-oddball
Copy link

@mjones-oddball
Copy link

Please add your planning poker estimate with Zenhub @justaskdavidb2

@cris-oddball cris-oddball changed the title Properly delete the database after all workers finish TODO: Properly delete the database after all workers finish Sep 12, 2023
@cris-oddball cris-oddball changed the title TODO: Properly delete the database after all workers finish TODO: Properly delete the test database Sep 12, 2023
@mjones-oddball
Copy link

Hey team! Please add your planning poker estimate with Zenhub @nikolai-efimov @ldraney

@kalbfled kalbfled changed the title TODO: Properly delete the test database Delete the test database after each test run Oct 27, 2023
@mjones-oddball
Copy link

@k-macmillan you mentioned this will be handled as part of #1436. Assuming that happens please close this ticket.

@npmartin-oddball
Copy link

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants