Add support for LSP/tsserver Code Actions

[rlerm]

Right now, there is no support for using :ALEFix for LSP-based linters. The protocol supports this (via codeAction), although it might be somewhat complex.

[w0rp]

I'm interested in supporting this, and also something similar for tsserver, which I consider close enough to LSP servers to support both. Both offer "quick fix" actions for fixing a specific problem in a number of ways, probably across multiple files. In the first instance, I'm interested in seeing if there's a way to fix all known problems automatically for a given buffer with both protocols.

[w0rp]

After giving this some thought, I think the best way to support fixing files via Language Server Protocol is to not apply fixes to files in the pipeline of fixes for :ALEFix, but to handle code actions separately. Code actions will likely need to write the files they change to disk in many cases, and will also support actions on ranges. What ALE ought to do is ask the server what actions are available for either a range in a document or the whole document, and then have you selection an option to apply.

ALE should support code actions primarily via some commands, and secondarily via the GVim mouse-controlled context menu. There should be some way to issue code actions without first loading the list of actions.

[jeffwillette]

Is there any update on the feasibility of this. I am not happy with any of the vim typescript plugins which offer this functionality and ALE does everything except auto fixes on typescript.

Is there a way to add an optionality interface to ALEfix and then people can write requests to the LS in fixers and have a callback that sends the options to the user?

[w0rp]

If there's something to update this issue with, I'll post a comment. What I said before about code actions still applies.

[jazmit]

+1. Code actions are the last blocker before I can dispense with VSCode. Maybe it would make sense to rename this issue to 'Support code actions'? Are there any known workarounds/hacks to get code actions working?

[w0rp]

ca2026b

I was playing around with adding support for code actions with popup menu support, so you can just right click on regions of code to perform action. GVim supports updating the popup menu while it's still open, and you can trigger requesting some actions whenever the menu is opened, so it will be pretty good.

I'll try to get back on this when I can. I plan to get the popup menu support to be pretty good first, and then add console menu support second for terminals. The hardest part is just applying edits to files that may or may not be open in Vim already.

[w0rp]

Parts of the code required for implementing code actions were previously added to the codebase to support rename operations and organising imports. See here: #2709

[ta3pks]

👍

[ta3pks]

just waiting for this feature to go back to ale from vim-lsp I love ale's plug-n-play approach