-
Notifications
You must be signed in to change notification settings - Fork 359
Closed
Description
Hi, github now provides ubuntu-arm images: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories .
It means you don't have to maintain the cross-compilation pipeline in github actions here:
rusty_v8/.github/workflows/ci.yml
Lines 136 to 151 in 9cd5842
| - name: Install cross compilation toolchain | |
| if: matrix.config.target == 'aarch64-unknown-linux-gnu' | |
| run: | | |
| rustup target add aarch64-unknown-linux-gnu | |
| sudo apt update | |
| sudo apt install -yq --no-install-suggests --no-install-recommends \ | |
| binfmt-support g++-10-aarch64-linux-gnu g++-10-multilib \ | |
| gcc-10-aarch64-linux-gnu libc6-arm64-cross qemu qemu-user \ | |
| qemu-user-binfmt | |
| sudo ln -s /usr/aarch64-linux-gnu/lib/ld-linux-aarch64.so.1 \ | |
| /lib/ld-linux-aarch64.so.1 | |
| echo "CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER=/usr/bin/aarch64-linux-gnu-gcc-10" >> ${GITHUB_ENV} | |
| echo "QEMU_LD_PREFIX=/usr/aarch64-linux-gnu" >> ${GITHUB_ENV} |
If you want, you can directly use ubuntu-22.04-arm image to replace the ubuntu-22.04 here:
rusty_v8/.github/workflows/ci.yml
Lines 90 to 100 in 9cd5842
| - os: ${{ github.repository == 'denoland/rusty_v8' && 'ubuntu-22.04-xl' || 'ubuntu-22.04' }} | |
| target: aarch64-unknown-linux-gnu | |
| variant: debug | |
| v8_enable_pointer_compression: false | |
| cargo: cargo | |
| - os: ${{ github.repository == 'denoland/rusty_v8' && 'ubuntu-22.04-xl' || 'ubuntu-22.04' }} | |
| target: aarch64-unknown-linux-gnu | |
| variant: release | |
| v8_enable_pointer_compression: false | |
| cargo: cargo |
Which will be much easier for both code logic and maintanence effort.
Metadata
Metadata
Assignees
Labels
No labels