Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP tests are sensitive to changes of global symbols #23102

Closed
bartlomieju opened this issue Mar 27, 2024 · 4 comments · Fixed by #27806
Closed

LSP tests are sensitive to changes of global symbols #23102

bartlomieju opened this issue Mar 27, 2024 · 4 comments · Fixed by #27806
Labels
chore something that we should get around to eventually lsp related to the language server tests related to tests

Comments

@bartlomieju
Copy link
Member

As seen in eg. #22054 adding new global symbols requires us to update tests for the LSP.

It feels strange that touching an unrelated part of the codebase requires updates to a test that says lsp_jsr_autom_import_completion_import_map(). These two are completely unrelated. We should tweak the test to not require these changes if new global symbols are added (or removed).

@bartlomieju bartlomieju added tests related to tests chore something that we should get around to eventually lsp related to the language server labels Mar 27, 2024
@nayeemrmn
Copy link
Collaborator

I think this is not applicable anymore, that test isn't being touched in #27527.

@petamoriken
Copy link
Contributor

@nayeemrmn Apparently, this is still applicable. a37d769

@nayeemrmn nayeemrmn reopened this Jan 23, 2025
@nayeemrmn
Copy link
Collaborator

@petamoriken You can just remove those assertions I believe.

@petamoriken
Copy link
Contributor

I created a separete PR: #27806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore something that we should get around to eventually lsp related to the language server tests related to tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants