Delta Version 0.24 no longer allows disabling the conflict checker

[daphnenhuch-at]

Description

Use Case
I would like to disable use of the ConflictChecker and simply throw an error if the user tries to update the table with a stale version. I used to do this by setting max_retries=1 in CommitProperties. In version 0.20.1 this would work because a conflict would be detected but we would never retry and apply the conflict checker's resolution. However, in more recent versions, the conflict checker is called BEFORE the attempt for the first commit which makes disabling the functionality impossible. It would be very much appreciated if a CommitProperty or something similar could allow us to specify whether we want to enable the Conflict Checker's behavior.

Related Issue(s)

[ion-elgreco]

Our max_retries actually is more of a max_tries because if you set max_retries=1 it never retries, but only runs once.

We should start counting the attempt_number at 0, so that max_retries 1 actually means you retry once only.

We can probably add a disable_conflict_checker in commit properties but it implies overruling the commit retries.

Can you contribute this?

[daphnenhuch-at]

I can give it a try. Is there a contribution guide somewhere for this? Can I mark you as a reviewer?

[daphnenhuch-at]

Was there as reason why the behavior changed and it checks for conflicts before trying once? Or can I just change the order back so logically it only checks for conflicts if the commit throws an error in the first place?

[ion-elgreco]

It was to improve writer concurrency.

Yes there is a contributing guide in the root of the repo. I'll be auto added as a reviewer when you put in a fix