Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated columns feature needs to be checked #3180

Open
ion-elgreco opened this issue Feb 2, 2025 · 2 comments
Open

Generated columns feature needs to be checked #3180

ion-elgreco opened this issue Feb 2, 2025 · 2 comments
Assignees
@JustinRush80
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ion-elgreco
Copy link
Collaborator

ion-elgreco commented Feb 2, 2025 •
edited
Loading

Environment

I never added a validation whether generated columns feature is enabled in the tablefeatures or writer version 5 is enabled, we should add a check before running GC code just to be sure.
@ion-elgreco ion-elgreco added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Feb 2, 2025
@ion-elgreco ion-elgreco changed the title Generated columns feature needs to be checker Generated columns feature needs to be checked Feb 2, 2025
@JustinRush80
Copy link
Contributor

I can take this!

@ion-elgreco
Copy link
Collaborator Author

Great, thanks @JustinRush80!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinRush80 JustinRush80

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ion-elgreco @JustinRush80