Formatting logs for Matching Instance & Result

Author: 24santoshr

src/main/scala/de/upb/cs/swt/delphi/instanceregistry/RequestHandler.scala

@@ -129,19 +129,19 @@ class RequestHandler(configuration: Configuration, instanceDao: InstanceDAO, con
     } else {
       tryLinkMatching(callerId, compType) match {
         case Success(instance) =>
-          log.info(s"Matching finished: First try yielded result $instance.")
+          log.debug(s"Matching finished: First try yielded result $instance.")
           (OperationResult.Ok, Success(instance))
         case Failure(ex) =>
           log.warning(s"Matching pending: First try failed, message was ${ex.getMessage}")
           tryLabelMatching(callerId, compType) match {
             case Success(instance) =>
-              log.info(s"Matching finished: Second try yielded result $instance.")
+              log.debug(s"Matching finished: Second try yielded result $instance.")
               (OperationResult.Ok, Success(instance))
             case Failure(ex2) =>
               log.warning(s"Matching pending: Second try failed, message was ${ex2.getMessage}")
               tryDefaultMatching(compType) match {
                 case Success(instance) =>
-                  log.info(s"Matching finished: Default matching yielded result $instance.")
+                  log.debug(s"Matching finished: Default matching yielded result $instance.")
                   (OperationResult.Ok, Success(instance))
                 case Failure(ex3) =>
                   log.warning(s"Matching failed: Default matching did not yield result, message was ${ex3.getMessage}.")
@@ -228,7 +228,7 @@ class RequestHandler(configuration: Configuration, instanceDao: InstanceDAO, con
         instanceDao.setStateFor(matchedInstanceId, InstanceState.NotReachable)
         fireStateChangedEvent(instanceDao.getInstance(matchedInstanceId).get) //Re-retrieve instance bc reference was invalidated by 'setStateFor'
       }
-      log.info(s"Applied matching result $matchingSuccess to instance with id $matchedInstanceId.")
+      log.debug(s"Applied matching result $matchingSuccess to instance with id $matchedInstanceId.")
 
       //Update link state
       if (!matchingSuccess) {
@@ -269,13 +269,13 @@ class RequestHandler(configuration: Configuration, instanceDao: InstanceDAO, con
 
         deployResult match {
           case Failure(ex) =>
-            log.error(s"Failed to deploy container, docker host not reachable.")
+            log.warning(s"Failed to deploy container, docker host not reachable.")
             instanceDao.removeInstance(id)
             fireDockerOperationErrorEvent(None, s"Deploy failed with message: ${ex.getMessage}")
             Failure(new RuntimeException(s"Failed to deploy container, docker host not reachable (${ex.getMessage})."))
           case Success((dockerId, host, port)) =>
             val normalizedHost = host.substring(1, host.length - 1)
-            log.info(s"Deployed new '$componentType' container with docker id: $dockerId, host: $normalizedHost and port: $port.")
+            log.info(s"Deployed new $componentType container with docker id: $dockerId, host: $normalizedHost and port: $port.")
 
             val newInstance = Instance(Some(id),
               normalizedHost,
@@ -419,7 +419,7 @@ class RequestHandler(configuration: Configuration, instanceDao: InstanceDAO, con
     } else {
       val instance = instanceDao.getInstance(id).get
       if (instance.instanceState == InstanceState.Running) {
-        log.info(s"Handling /pause for instance with id $id...")
+        log.debug(s"Handling /pause for instance with id $id...")
         implicit val timeout: Timeout = configuration.dockerOperationTimeout
 
         (dockerActor ? pause(instance.dockerId.get)).map {
@@ -455,7 +455,7 @@ class RequestHandler(configuration: Configuration, instanceDao: InstanceDAO, con
     } else {
       val instance = instanceDao.getInstance(id).get
       if (instance.instanceState == InstanceState.Paused) {
-        log.info(s"Handling /resume for instance with id $id...")
+        log.debug(s"Handling /resume for instance with id $id...")
         implicit val timeout: Timeout = configuration.dockerOperationTimeout
 
         (dockerActor ? unpause(instance.dockerId.get)).map {
@@ -493,7 +493,7 @@ class RequestHandler(configuration: Configuration, instanceDao: InstanceDAO, con
         log.warning(s"Cannot stop instance of type ${instance.componentType}.")
         OperationResult.InvalidTypeForOperation
       } else {
-        log.info(s"Calling /stop on non-docker instance $instance..")
+        log.debug(s"Calling /stop on non-docker instance $instance..")
         RestClient.executePost(RestClient.getUri(instance) + "/stop").map {
           response =>
             log.info(s"Request to /stop returned $response")
@@ -751,13 +751,13 @@ class RequestHandler(configuration: Configuration, instanceDao: InstanceDAO, con
     * @return Try[Instance], Success if matching was successful, Failure otherwise
     */
   private def tryLinkMatching(callerId: Long, componentType: ComponentType): Try[Instance] = {
-    log.info(s"Matching first try: Analyzing links for $callerId...")
+    log.debug(s"Matching first try: Analyzing links for $callerId...")
 
     val links = instanceDao.getLinksFrom(callerId).filter(link => link.linkState == LinkState.Assigned)
 
     links.size match {
       case 0 =>
-        log.info(s"Matching first try failed: No links present.")
+        log.debug(s"Matching first try failed: No links present.")
         Failure(new RuntimeException("No links for instance."))
       case 1 =>
         val instanceAssigned = instanceDao.getInstance(links.head.idTo)
@@ -817,13 +817,13 @@ class RequestHandler(configuration: Configuration, instanceDao: InstanceDAO, con
     * @return Success(Instance) if successful, Failure otherwise.
     */
   private def tryLabelMatching(callerId: Long, componentType: ComponentType): Try[Instance] = {
-    log.info(s"Matching second try: Analyzing labels for $callerId...")
+    log.debug(s"Matching second try: Analyzing labels for $callerId...")
 
     val possibleMatches = instanceDao.getInstancesOfType(componentType)
 
     possibleMatches.size match {
       case 0 =>
-        log.warning(s"Matching second try failed: There are no instances of type $componentType present.")
+        log.debug(s"Matching second try failed: There are no instances of type $componentType present.")
         Failure(new RuntimeException(s"Type $componentType not present."))
       case _ =>
         val labels = instanceDao.getInstance(callerId).get.labels
@@ -839,17 +839,17 @@ class RequestHandler(configuration: Configuration, instanceDao: InstanceDAO, con
           log.info(s"Finished matching second try: Successfully matched to  $result based on $noOfSharedLabels shared labels.")
           Success(result)
         } else {
-          log.warning(s"Matching second try failed: There are no instance with shared labels to $labels.")
+          log.debug(s"Matching second try failed: There are no instance with shared labels to $labels.")
           Failure(new RuntimeException(s"No instance with shared labels."))
         }
     }
   }
 
   private def tryDefaultMatching(componentType: ComponentType): Try[Instance] = {
-    log.info(s"Matching fallback: Searching for instances of type $componentType ...")
+    log.debug(s"Matching fallback: Searching for instances of type $componentType ...")
     getNumberOfInstances(componentType) match {
       case 0 =>
-        log.error(s"Matching failed: Cannot match to any instance of type $componentType, no such instance present.")
+        log.warning(s"Matching failed: Cannot match to any instance of type $componentType, no such instance present.")
         Failure(new RuntimeException(s"Cannot match to any instance of type $componentType, no instance present."))
       case 1 =>
         val instance: Instance = instanceDao.getInstancesOfType(componentType).head

src/main/scala/de/upb/cs/swt/delphi/instanceregistry/connection/Server.scala

@@ -314,7 +314,7 @@ class Server(handler: RequestHandler) extends HttpApp
         log.debug(s"GET instance/$id/matchingInstance?ComponentType=$compTypeString has been called")
 
         val compType: ComponentType = ComponentType.values.find(v => v.toString == compTypeString).orNull
-        log.info(s"Looking for instance of type $compType ...")
+        log.debug(s"Looking for instance of type $compType ...")
 
         if (compType != null) {
           handler.getMatchingInstanceOfType(id, compType) match {
@@ -344,7 +344,7 @@ class Server(handler: RequestHandler) extends HttpApp
               complete(HttpResponse(StatusCodes.NotFound, entity = s"Could not find matching instance of type $compType for instance with id $id."))
           }
         } else {
-          log.error(s"Failed to deserialize parameter string $compTypeString to ComponentType.")
+          log.warning(s"Failed to deserialize parameter string $compTypeString to ComponentType.")
           complete(HttpResponse(StatusCodes.BadRequest, entity = s"Could not deserialize parameter string $compTypeString to ComponentType"))
         }
       }