Skip to content

Commit 192e1bc

Browse files
Merge pull request #100 from delphi-hub/feature/harmonizeLogs
Harmonized logging output
2 parents a03ee27 + 51418a2 commit 192e1bc

File tree

5 files changed

+75
-152
lines changed

5 files changed

+75
-152
lines changed

src/main/scala/de/upb/cs/swt/delphi/instanceregistry/Docker/DockerActor.scala

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
package de.upb.cs.swt.delphi.instanceregistry.Docker
22

33
import akka.actor.{Actor, ActorLogging, ActorSystem, Props, Status}
4-
import akka.http.scaladsl.model.ws.Message
54
import akka.stream.ActorMaterializer
65
import de.upb.cs.swt.delphi.instanceregistry.Docker.DockerActor._
76
import de.upb.cs.swt.delphi.instanceregistry.Registry
87
import de.upb.cs.swt.delphi.instanceregistry.io.swagger.client.model.InstanceEnums.ComponentType
9-
import org.reactivestreams.Publisher
108

119
import scala.concurrent.duration._
12-
import scala.concurrent.{Await, ExecutionContext, Future}
10+
import scala.concurrent.{Await, ExecutionContext}
1311
import scala.util.{Failure, Success, Try}
1412

1513
class DockerActor(connection: DockerConnection) extends Actor with ActorLogging {
@@ -27,13 +25,13 @@ class DockerActor(connection: DockerConnection) extends Actor with ActorLogging
2725
def receive: PartialFunction[Any, Unit] = {
2826

2927
case start(containerId) =>
30-
log.info(s"Docker Container started")
31-
Try(Await.result(container.start(containerId), Duration.Inf)) match {
32-
case Success(_) =>
33-
sender ! Status.Success
34-
case Failure(ex) =>
35-
sender ! Status.Failure(ex)
36-
}
28+
log.debug(s"Docker Container started")
29+
Try(Await.result(container.start(containerId), Duration.Inf)) match {
30+
case Success(_) =>
31+
sender ! Status.Success
32+
case Failure(ex) =>
33+
sender ! Status.Failure(ex)
34+
}
3735

3836
case create(componentType, instanceId, containerName) =>
3937

@@ -74,7 +72,7 @@ class DockerActor(connection: DockerConnection) extends Actor with ActorLogging
7472
}
7573

7674
case stop(containerId) =>
77-
log.info(s"Stopping docker container..")
75+
log.debug(s"Stopping docker container..")
7876

7977
Try(Await.result(container.stop(containerId), Duration.Inf)) match {
8078
case Success(_) =>
@@ -84,9 +82,8 @@ class DockerActor(connection: DockerConnection) extends Actor with ActorLogging
8482
}
8583

8684

87-
8885
case delete(containerId) =>
89-
log.info(s"Deleting docker container..")
86+
log.debug(s"Deleting docker container..")
9087
Try(Await.result(container.remove(containerId, force = false, removeVolumes = false), Duration.Inf)) match {
9188
case Success(_) =>
9289
sender ! Status.Success
@@ -95,7 +92,7 @@ class DockerActor(connection: DockerConnection) extends Actor with ActorLogging
9592
}
9693

9794
case pause(containerId) =>
98-
log.info(s"Pausing docker container..")
95+
log.debug(s"Pausing docker container..")
9996
Try(Await.result(container.pause(containerId), Duration.Inf)) match {
10097
case Success(_) =>
10198
sender ! Status.Success
@@ -104,7 +101,7 @@ class DockerActor(connection: DockerConnection) extends Actor with ActorLogging
104101
}
105102

106103
case unpause(containerId) =>
107-
log.info(s"Unpausing docker container..")
104+
log.debug(s"Unpausing docker container..")
108105
Try(Await.result(container.unpause(containerId), Duration.Inf)) match {
109106
case Success(_) =>
110107
sender ! Status.Success
@@ -113,7 +110,7 @@ class DockerActor(connection: DockerConnection) extends Actor with ActorLogging
113110
}
114111

115112
case restart(containerId) =>
116-
log.info(s"Restarting docker container..")
113+
log.debug(s"Restarting docker container..")
117114
Try(Await.result(container.restart(containerId), Duration.Inf)) match {
118115
case Success(_) =>
119116
sender ! Status.Success
@@ -122,7 +119,7 @@ class DockerActor(connection: DockerConnection) extends Actor with ActorLogging
122119
}
123120

124121
case runCommand(containerId, command, attachStdin, attachStdout, attachStderr, detachKeys, privileged, tty, user) =>
125-
log.info(s"running command in docker container..")
122+
log.debug(s"running command in docker container..")
126123
val createCommand = Try(Await.result(container.commandCreate(containerId, command, attachStdin, attachStdout, attachStderr, detachKeys, privileged, tty, user), Duration.Inf))
127124
createCommand match {
128125
case Failure(ex) => sender ! Failure(ex)
@@ -140,7 +137,7 @@ class DockerActor(connection: DockerConnection) extends Actor with ActorLogging
140137

141138
log.info(s"Fetching Container logs: stdErrSelected -> $stdErrSelected, stream -> $stream")
142139

143-
if(!stream){
140+
if (!stream) {
144141
val logResult = Try(Await.result(container.retrieveLogs(containerId, stdErrSelected), Duration.Inf))
145142
logResult match {
146143
case Failure(ex) =>
@@ -189,4 +186,5 @@ object DockerActor {
189186
tty: Option[Boolean],
190187
user: Option[String]
191188
)
189+
192190
}

src/main/scala/de/upb/cs/swt/delphi/instanceregistry/Docker/Image.scala

Lines changed: 0 additions & 81 deletions
This file was deleted.

src/main/scala/de/upb/cs/swt/delphi/instanceregistry/Registry.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,7 @@ object Registry extends AppLogging {
4040

4141
def main(args: Array[String]): Unit = {
4242
requestHandler.initialize()
43-
log.info("Starting server ...")
4443
server.startServer(configuration.bindHost, configuration.bindPort)
45-
log.info("Shutting down ...")
4644
requestHandler.shutdown()
4745
system.terminate()
4846
}

0 commit comments

Comments
 (0)