Skip to content

Commit 0f3799c

Browse files
authored
Merge pull request #111 from delphi-hub/bugfix/actorSystem
Trying to fix race condition for CI tests
2 parents 9780e92 + 0382a49 commit 0f3799c

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

src/main/scala/de/upb/cs/swt/delphi/instanceregistry/Docker/DockerConnection.scala

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@ import akka.http.scaladsl.Http
2020
import akka.http.scaladsl.model.Uri.{Path, Query}
2121
import akka.http.scaladsl.model.{HttpRequest, HttpResponse, Uri}
2222
import akka.stream.Materializer
23-
import de.upb.cs.swt.delphi.instanceregistry.Configuration
23+
import de.upb.cs.swt.delphi.instanceregistry.{Configuration, Registry}
2424

2525
import scala.concurrent.Future
2626

2727
object DockerConnection {
2828

2929

30-
def fromEnvironment(configuration: Configuration) (implicit system: ActorSystem, mat: Materializer): DockerConnection = {
30+
def fromEnvironment(configuration: Configuration): DockerConnection = {
3131
DockerHttpConnection(configuration.dockerUri)
3232
}
3333
}
@@ -48,10 +48,11 @@ trait DockerConnection {
4848

4949
}
5050

51-
case class DockerHttpConnection(
52-
baseUri: Uri,
53-
)(implicit val system: ActorSystem, val materializer: Materializer)
51+
case class DockerHttpConnection(baseUri: Uri)
5452
extends DockerConnection {
53+
override def system: ActorSystem = Registry.system
54+
override implicit def materializer: Materializer = Registry.materializer
55+
5556
override def sendRequest(request: HttpRequest): Future[HttpResponse] = {
5657
Http(system).singleRequest(request)
5758
}

src/test/scala/de/upb/cs/swt/delphi/instanceregistry/RequestHandlerTest.scala

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ import org.scalatest.{BeforeAndAfterEach, FlatSpec, Matchers}
2828

2929
class RequestHandlerTest extends FlatSpec with Matchers with BeforeAndAfterEach {
3030

31-
implicit val system : ActorSystem = ActorSystem("test_system")
32-
implicit val materializer : ActorMaterializer = ActorMaterializer()
33-
3431
val configuration: Configuration = new Configuration()
3532
val dao: InstanceDAO = new DynamicInstanceDAO(configuration)
3633
val authDAO: AuthDAO = new DynamicAuthDAO(configuration)

src/test/scala/de/upb/cs/swt/delphi/instanceregistry/connection/ServerTest.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,6 @@ class ServerTest
7474
*/
7575
override def afterAll(): Unit = {
7676
requestHandler.shutdown()
77-
Await.ready(Registry.system.terminate(), Duration.Inf)
78-
Await.ready(system.terminate(), Duration.Inf)
7977
}
8078

8179
"The Server" should {

0 commit comments

Comments
 (0)