Skip to content

Commit 905426a

Browse files
committed
minor changes to dialog implementation to test behavior on firefox
1 parent a4585d2 commit 905426a

File tree

3 files changed

+25
-27
lines changed

3 files changed

+25
-27
lines changed
Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
1-
<div>
2-
<h2 mat-dialog-title>Add Instance</h2>
3-
<mat-dialog-content>
4-
<form class="mat-dialog-content" #formControl="ngForm">
5-
<div class="form">
6-
<mat-form-field color="primary">
7-
<input matInput #input class="form-control" placeholder="Name" [(ngModel)]="name" name="name" required>
8-
<mat-error *ngIf="formControl.invalid">{{getErrorMessage()}}</mat-error>
9-
</mat-form-field>
10-
</div>
11-
</form>
12-
</mat-dialog-content>
13-
<mat-dialog-actions>
14-
<button mat-raised-button color="primary" [disabled]="!formControl.valid" [mat-dialog-close]="1" id="confirmButton" (click)="onConfirmAddInstance()">Add</button>
15-
<button mat-raised-button (click)="onCloseCancle()">Cancle</button>
16-
</mat-dialog-actions>
17-
</div>
1+
2+
<h2 mat-dialog-title>Add Instance</h2>
3+
<div mat-dialog-content>
4+
<form class="mat-dialog-content" #formControl="ngForm">
5+
<div class="form">
6+
<mat-form-field color="primary">
7+
<input matInput #input class="form-control" placeholder="Name" [(ngModel)]="name" name="name" required>
8+
<mat-error *ngIf="formControl.invalid">{{getErrorMessage()}}</mat-error>
9+
</mat-form-field>
10+
</div>
11+
</form>
12+
</div>
13+
<mat-dialog-actions>
14+
<button mat-raised-button color="primary" [disabled]="!formControl.valid" [mat-dialog-close]="1" id="confirmButton" (click)="onConfirmAddInstance()">Add</button>
15+
<button mat-raised-button (click)="onCloseCancle()">Cancle</button>
16+
</mat-dialog-actions>

client/src/app/dashboard/delete-dialog/delete-dialog.component.html

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,10 @@
1616
~ limitations under the License.
1717
-->
1818

19-
<div>
20-
<h2 mat-dialog-title>Delete Instance</h2>
21-
<mat-dialog-content>Are you sure you want to delete "{{data.name}}" instance?</mat-dialog-content>
22-
<mat-dialog-actions>
23-
<button mat-raised-button color="primary" [mat-dialog-close]="1" (click)="onCloseConfirm()">Confirm</button>
24-
<button mat-raised-button color="primary" (click)="onCloseCancle()">Cancle</button>
25-
</mat-dialog-actions>
26-
</div>
19+
20+
<h2 mat-dialog-title>Delete Instance</h2>
21+
<mat-dialog-content>Are you sure you want to delete "{{data.name}}" instance?</mat-dialog-content>
22+
<mat-dialog-actions>
23+
<button mat-raised-button color="primary" [mat-dialog-close]="1" (click)="onCloseConfirm()">Confirm</button>
24+
<button mat-raised-button color="primary" (click)="onCloseCancle()">Cancle</button>
25+
</mat-dialog-actions>

client/src/app/dashboard/table-all/table-all.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@
6464
<button mat-icon-button (click)= resumeInstance(element.id) matTooltip="Resume">
6565
<mat-icon aria-label="play_circle_outline">play_circle_outline</mat-icon>
6666
</button>
67-
<button id="deleteButton" mat-icon-button matTooltip="Delete">
68-
<mat-icon aria-label="delete" id="deleteButton" (click)="openDeleteDialog(i,row, element.id)">delete</mat-icon>
67+
<button id="deleteButton" (click)="openDeleteDialog(i,row, element.id)" mat-icon-button matTooltip="Delete">
68+
<mat-icon aria-label="delete" id="deleteButton" >delete</mat-icon>
6969
</button>
7070
</mat-cell>
7171
</ng-container>

0 commit comments

Comments
 (0)