Skip to content

Commit 6b0310b

Browse files
committed
updated test cases to fit new modelservice
1 parent eabfb48 commit 6b0310b

File tree

6 files changed

+25
-24
lines changed

6 files changed

+25
-24
lines changed

client/src/app/dashboard/add-dialog/add-dialog.component.spec.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,6 @@ describe('AddDialogComponent', () => {
4040
fixture.detectChanges();
4141
});
4242

43-
44-
it(`should create Add dialog Component`, async(inject([HttpTestingController, ApiService],
45-
(httpClient: HttpTestingController, apiService: ApiService) => {
46-
expect(apiService).toBeTruthy();
47-
})));
48-
4943
it('should check for confirm button inside the Add dialog', () => {
5044
component.onConfirmAddInstance();
5145
expect(mockDialogRef.close).toHaveBeenCalled();

client/src/app/dashboard/crawler/crawler.component.spec.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,10 @@ import { MatIconModule} from '@angular/material/icon';
2727
import { MatDialogModule} from '@angular/material/dialog';
2828
import { TableAllComponent } from '../table-all/table-all.component';
2929
import { CrawlerComponent } from './crawler.component';
30-
import { ApiService } from 'src/app/api/api/api.service';
30+
import { ModelService } from 'src/app/model/model.service';
3131

3232

3333
describe('CrawlerComponent', () => {
34-
let component: CrawlerComponent;
3534
let fixture: ComponentFixture<CrawlerComponent>;
3635

3736
beforeEach(async(() => {
@@ -45,12 +44,11 @@ describe('CrawlerComponent', () => {
4544

4645
beforeEach(() => {
4746
fixture = TestBed.createComponent(CrawlerComponent);
48-
component = fixture.componentInstance;
4947
fixture.detectChanges();
5048
});
5149

52-
it(`should create`, async(inject([HttpTestingController, ApiService],
53-
(httpClient: HttpTestingController, apiService: ApiService) => {
54-
expect(apiService).toBeTruthy();
50+
it(`should create`, async(inject([HttpTestingController, ModelService],
51+
(modelService: ModelService) => {
52+
expect(modelService).toBeTruthy();
5553
})));
5654
});

client/src/app/dashboard/crawler/crawler.component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
*/
1818

1919
import {Component, OnInit} from '@angular/core';
20-
import { Instance, ComponentType} from '../../model/models/instance';
21-
import { ModelService, InstanceChange } from 'src/app/model/model.service';
20+
import { Instance, ComponentType, ComponentTypeEnum} from '../../model/models/instance';
21+
import { ModelService } from 'src/app/model/model.service';
2222

2323

2424
@Component({
@@ -38,7 +38,7 @@ export class CrawlerComponent implements OnInit {
3838

3939
ngOnInit() {
4040
this.modelService.getObservableForInstances().subscribe(() => {
41-
this.tableData = this.modelService.getComponentsByType(this.compType);
41+
this.tableData = this.modelService.getComponentsByType(ComponentTypeEnum.Crawler);
4242
});
4343
}
4444

client/src/app/dashboard/webapi/web-api.component.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ import { HttpClientModule } from '@angular/common/http';
2222
import { BrowserAnimationsModule} from '@angular/platform-browser/animations';
2323
import { TableAllComponent } from '../table-all/table-all.component';
2424
import { WebApiComponent } from './web-api.component';
25-
import { ApiService } from '../../api/api/api.service';
2625
import { MaterialModule } from 'src/app/material-module/material.module';
26+
import { ModelService } from 'src/app/model/model.service';
2727

2828

2929
describe('WebApiComponent', () => {
@@ -43,8 +43,8 @@ describe('WebApiComponent', () => {
4343
fixture.detectChanges();
4444
});
4545

46-
it(`should create`, async(inject([HttpTestingController, ApiService],
47-
(apiService: ApiService) => {
48-
expect(apiService).toBeTruthy();
46+
it(`should create`, async(inject([HttpTestingController, ModelService],
47+
(modelService: ModelService) => {
48+
expect(modelService).toBeTruthy();
4949
})));
5050
});

client/src/app/dashboard/webapp/webapp.component.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ import { HttpClientModule } from '@angular/common/http';
2222
import { BrowserAnimationsModule} from '@angular/platform-browser/animations';
2323
import { TableAllComponent } from '../table-all/table-all.component';
2424
import { WebappComponent } from './webapp.component';
25-
import { ApiService } from 'src/app/api/api/api.service';
2625
import { MaterialModule } from 'src/app/material-module/material.module';
26+
import { ModelService } from 'src/app/model/model.service';
2727

2828

2929
describe('WebappComponent', () => {
@@ -43,8 +43,8 @@ describe('WebappComponent', () => {
4343
fixture.detectChanges();
4444
});
4545

46-
it(`should create`, async(inject([HttpTestingController, ApiService],
47-
(httpClient: HttpTestingController, apiService: ApiService) => {
48-
expect(apiService).toBeTruthy();
46+
it(`should create`, async(inject([HttpTestingController, ModelService],
47+
(modelService: ModelService) => {
48+
expect(modelService).toBeTruthy();
4949
})));
5050
});

client/src/app/model/model.service.spec.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,18 @@
11
import {TestBed} from '@angular/core/testing';
22

33
import {ModelService} from './model.service';
4+
import { HttpClientTestingModule } from '@angular/common/http/testing';
5+
import { HttpClientModule } from '@angular/common/http';
46

57
describe('ModelService', () => {
6-
beforeEach(() => TestBed.configureTestingModule({}));
8+
9+
beforeEach(() => {
10+
TestBed.configureTestingModule({
11+
imports: [HttpClientTestingModule, HttpClientModule],
12+
providers: [ModelService],
13+
});
14+
15+
});
716

817
it('should be created', () => {
918
const service: ModelService = TestBed.get(ModelService);

0 commit comments

Comments
 (0)