Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests for API Package #91

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

harshitap26
Copy link
Contributor

Description

PR to add unit tests for the API package for code coverage

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained at least 90% code coverage?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Added Unit tests and made changes only to the test file. The newly added or updated Unit tests execute successfully

@bharathsreekanth
Copy link
Contributor

@harshitap26 Do you also want to edit the unit-test step in Makefile?

@harshitap26 harshitap26 merged commit 5a8d27f into usr/spark/ut-datarace-csi-powermax Feb 14, 2025
7 checks passed
@harshitap26 harshitap26 deleted the usr/spark/api_UT branch February 14, 2025 15:17
@harshitap26
Copy link
Contributor Author

@harshitap26 Do you also want to edit the unit-test step in Makefile?

Missed your review comment and merged the PR. I will add a commit once we create a PR against main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants